Skip to content

Fix for vehicle damage sync problems #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psychoo102 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for vehicle damage sync problems #568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7384da5
Fix for vehicle damage sync problems
psychoo102 Nov 29, 2024
b6f9a67
Merge branch 'master' into vehicledamagefix
CrosRoad95 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions SlipeServer.Server/PacketHandling/Handlers/Vehicle/Sync/VehicleDamageSyncPacketHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ public class VehicleDamageSyncPacketHandler : IPacketHandler<VehicleDamageSyncPa
private readonly IElementCollection elementCollection;

public PacketId PacketId => PacketId.PACKET_ID_VEHICLE_DAMAGE_SYNC;

private readonly int MAX_DOORS = 6;
private readonly int MAX_WHEELS = 4;
private readonly int MAX_PANELS = 6;
private readonly int MAX_LIGHTS = 16;

public VehicleDamageSyncPacketHandler(
ISyncHandlerMiddleware<VehicleDamageSyncPacket> middleware,
Expand All @@ -26,10 +31,8 @@ IElementCollection elementCollection

public void HandlePacket(IClient client, VehicleDamageSyncPacket packet)
{
var otherPlayers = this.middleware.GetPlayersToSyncTo(client.Player, packet);
packet.SendTo(otherPlayers);

var player = client.Player;
bool isChanged = false;

var vehicle = this.elementCollection.Get(packet.VehicleId) as Elements.Vehicle;

Expand All @@ -39,20 +42,42 @@ public void HandlePacket(IClient client, VehicleDamageSyncPacket packet)
{
foreach (var door in Enum.GetValues<VehicleDoor>())
if (packet.DoorStates[(int)door] != null)
{
vehicle.SetDoorState(door, (VehicleDoorState)packet.DoorStates[(int)door]!);
isChanged = true;
}

foreach (var wheel in Enum.GetValues<VehicleWheel>())
if (packet.WheelStates[(int)wheel] != null)
{
vehicle.SetWheelState(wheel, (VehicleWheelState)packet.WheelStates[(int)wheel]!);
isChanged = true;
}

foreach (var panel in Enum.GetValues<VehiclePanel>())
if (packet.PanelStates[(int)panel] != null)
{
vehicle.SetPanelState(panel, (VehiclePanelState)packet.PanelStates[(int)panel]!);
isChanged = true;
}

foreach (var light in Enum.GetValues<VehicleLight>())
if (packet.LightStates[(int)light] != null)
{
vehicle.SetLightState(light, (VehicleLightState)packet.LightStates[(int)light]!);
isChanged = true;
}
});
if (isChanged)
{
var syncPacket = new VehicleDamageSyncPacket() { VehicleId = vehicle.Id, };
for (int i = 0; i < this.MAX_DOORS; i++) syncPacket.DoorStates[i] = vehicle.Damage.Doors[i];
for (int i = 0; i < this.MAX_WHEELS; i++) syncPacket.WheelStates[i] = vehicle.Damage.Wheels[i];
for (int i = 0; i< this.MAX_PANELS; i++) syncPacket.PanelStates[i] = vehicle.Damage.Panels[i];
for (int i = 0; i< this.MAX_LIGHTS; i++) syncPacket.LightStates[i] = vehicle.Damage.Lights[i];
var otherPlayers = this.middleware.GetPlayersToSyncTo(client.Player, syncPacket);
syncPacket.SendTo(otherPlayers);
}
}
}
}