Flight plan pin-to-map + PNG export#338
Draft
msupino wants to merge 18 commits into
Draft
Conversation
This was referenced May 26, 2026
Owner
Author
Refactor: replaced pin-to-map with placement pickerThe pin-button + drag/resize flow was awkward — user had to commit to a position before seeing the print frame, in a separate flow from Export. Rebuilt as a single 6-button row inside the Export PNG modal:
Removed:
Canvas Branch was force-pushed to resolve the conflict with dev (28 superseded pin-era commits collapsed into one coherent refactor on top of current dev). Tests:
|
auto-merge was automatically disabled
May 27, 2026 06:41
Pull request was converted to draft
Change page.goto('/?lang=en') to page.goto('?lang=en') in all test
files so they resolve relative to the baseURL path instead of the
domain root. Fixes e2e-deployed tests hitting the production site
instead of the PR preview.
When EXPECTED_SHA env var is set (e2e-deployed workflow), each test verifies the deployed core.js SHA matches after the test runs. Catches cases where page.goto resolves to a different deployment than the intended preview.
tintFill only accepts one argument (hex). The second argument was an unused alpha override that should be removed. Notes always use the global yellowAlpha opacity.
Contributor
🚀 Preview deployed
Commit: |
# Conflicts: # docs/core.js # docs/he/strings.js # docs/index.html # docs/io.js # docs/style.css # tests/flight-plan.spec.js
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flight plan pin-to-map + PNG export. A pin button on the flight plan modal pins the table to the map as a draggable, four-corner resizable box.
Pinned mode
navaid.planPinlocalStoragescrH / (legs+2) * 0.85, cap 24px, floor 2px)ResizeObserverrecalculates font on any size changemax(150, min(500, legs+2 * 24 + 6))× 400px, centeredDist (NM)→Dist,Speed (kt)→Spd,Alt (ft)→Alttable-layout: fixedwith explicit percentage widths (#3%,From/To15%,Hdg/Spd/Time10%,Dist/Alt11%,Fuel15%)2px 4pxwhen pinned;max-width/max-heightremoved to respect explicit sizePNG export
drawFlightPlanTable()uses short headers when pinnedCI / tooling
--blocked-url-patterns="googletagmanager|google-analytics|doubleclick")Closes #336