Quick-action row above sections (replaces #191)#245
Draft
msupino wants to merge 9 commits into
Draft
Conversation
msupino
force-pushed
the
dev-191-quick-actions-v2
branch
from
99340ea to
c1299a0
Compare
msupino
force-pushed
the
dev-191-quick-actions-v2
branch
from
c1299a0 to
f964faf
Compare
5 most-used buttons moved out of their sections into a new top row (#tb-quick) so they work without expanding anything: ✏️ Add Waypoint, 📝 Add Note, ⌖ Fit, 📋 Flight Plan, ⬇ Export The original buttons are removed from Build / Numbers / Export sections — no duplicate IDs. Build keeps the search input + Reverse + Clear; Numbers keeps Airport Charts; Export keeps Import + Open in Google Earth. CSS-only #tb-quick — column inside the toolbar's existing flex, divider below to separate from the collapsible sections. No JS rewiring. Replaces the original PR #191 which was structurally incompatible with the activity-based sections shipped in #192. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
msupino
force-pushed
the
dev-191-quick-actions-v2
branch
from
f964faf to
879222f
Compare
14 tests: existence, no-duplicate-IDs, CSS, and functional tests for all 5 buttons (tool-add, tool-note, fit, plan, save).
This reverts commit b5d7c90.
Change page.goto('/?lang=en') to page.goto('?lang=en') in all test
files so they resolve relative to the baseURL path instead of the
domain root. Fixes e2e-deployed tests hitting the production site
instead of the PR preview.
When EXPECTED_SHA env var is set (e2e-deployed workflow), each test verifies the deployed core.js SHA matches after the test runs. Catches cases where page.goto resolves to a different deployment than the intended preview.
tintFill only accepts one argument (hex). The second argument was an unused alpha override that should be removed. Notes always use the global yellowAlpha opacity.
# Conflicts: # .github/workflows/deploy.yml # docs/index.html # docs/style.css # tests/smoke.spec.js
Contributor
🚀 Preview deployed
Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite of PR #191 on top of main's activity-based sections (Build/View/Numbers/Export from #192).
Why a rewrite
Original #191 was crafted before #192 landed. After #192 reshaped the sections, #191's diff conflicted at every section boundary and couldn't be cleanly rebased — the premise overlapped.
What changed
5 most-used buttons moved out of their sections into a new top row
#tb-quick, always visible:| ✏️ Add Waypoint | 📝 Add Note | ⌖ Fit | 📋 Flight Plan | ⬇ Export |
Sections trimmed accordingly:
No JS rewiring — same button IDs, same click handlers. Pure HTML + CSS.
Test plan
Closes
Old PR #191 should be closed in favour of this one.
🔗 Preview: https://msupino.github.io/NavigationApp/branch/dev-191-quick-actions-v2/