Skip to content

fix: honor OpenAPI matching and validation boundaries - #9

Merged
mstuart merged 1 commit into
mainfrom
maintenance/2026-10-28-validation
Oct 28, 2026
Merged

mstuart merged 1 commit into
mainfrom
maintenance/2026-10-28-validation

Conversation

@mstuart

@mstuart mstuart commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Correct eight independently reproduced request/matcher defects:

  • Check required and unknown JSON fields against own properties.
  • Reject object-prototype names as HTTP operations while preserving supported methods, including TRACE.
  • Preserve __proto__ path parameters as own data without changing the result object's prototype.
  • Honor concrete-path precedence when that path does not define the requested method.
  • Match case-insensitive content media ranges and select exact schemas before wildcard schemas.
  • Accept absent optional JSON bodies without parsing them as invalid JSON.
  • Inherit path-level query parameters and apply operation overrides without mutating the spec.
  • Validate scalar item types in root and property arrays, including nested arrays.

The matching behavior follows the OpenAPI Paths, Path Item and Request Body rules. Validation: all eight new regression tests fail on the original source; all 40 tests, TypeScript build, repository lint and diff checks pass on Node 24.19.0. Fresh-eyes review completed for all four files. No dependency, workflow or infrastructure changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T11:43:33.352360Z 65b0e9e Draft marked ready
🔒 Security Review ✅ Completed 2026-10-28T11:48:24.213363Z 65b0e9e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mstuart
mstuart marked this pull request as draft October 28, 2026 11:41
@mstuart
mstuart marked this pull request as ready for review October 28, 2026 11:42
@mstuart
mstuart merged commit f46047c into main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant