Skip to content

fix: validate JSON suffixes and untyped body media - #10

Merged
mstuart merged 1 commit into
mainfrom
maintenance/2026-11-04-correctness
Nov 4, 2026
Merged

mstuart merged 1 commit into
mainfrom
maintenance/2026-11-04-correctness

Conversation

@mstuart

@mstuart mstuart commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Structured +json request media bypass JSON syntax and field checks despite a matching schema. Validate their JSON representation, and compare bodies without Content-Type against the application/octet-stream fallback rather than skipping media checks.

Validation: both new regression groups fail on the base; all 42 tests, lint and TypeScript build pass. Wildcard media and absent response bodies remain covered. Sources: RFC 6839 section 3.1 and RFC 9110 section 8.3.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T02:39:32.779728Z efc6e2f PR opened
🔒 Security Review ✅ Completed 2026-11-04T02:45:14.589292Z efc6e2f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mstuart
mstuart merged commit 2f7e472 into main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant