KeyTips: a badge toggling a checkable menu item keeps the overlay at that level - #75
Merged
Merged
Conversation
…y at that level Checkable menu items keep their menu open by design. A KeyTip badge toggling one used to exit the overlay anyway, leaving the menu open behind a cleared overlay; the next Alt then tore the menu down and started over at the top (maintainer, 2026-09-12). The entry now carries KeepsOverlay: the leaf activates and the controller re-shows the current level for the next choice. Plain leaves still activate, dismiss the chain and exit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013qbF5ru6uh5w7fqhP3yoPE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkable menu items keep their menu open by design (Space, click, access key, badge — all toggle without dismissing). A KeyTip badge toggling one exited the overlay anyway, leaving the menu open behind a cleared overlay; the next Alt then tore the menu down and started over at the top.
The popup level builder now marks a checkable
MenuItementryKeepsOverlay; on activation the controller invokes it and re-shows the current level, so the next badge can toggle the next item. Plain leaves still activate, dismiss the chain and exit.MenuItemitself is untouched.Test:
KeyTipMenuNavigationTests.CheckableMenuItem_BadgeToggles_MenuAndOverlayStay. Bars 315 green.🤖 Generated with Claude Code
https://claude.ai/code/session_013qbF5ru6uh5w7fqhP3yoPE