KeyTips: badges follow arrow-key menu navigation; QAT customize drill; check boxes toggle on activation - #73
Merged
Conversation
…ustomize ▾ drills into its checklist; check boxes toggle on badge activation Maintainer, 2026-09-12. (1) With the overlay up, the arrow keys now carry the badges along: a submenu the keyboard opens (Right/Enter on a header row) or a sibling top-level menu reached by arrows gets a level pushed over its rows — the popup's placement target is one of the shown level's badged controls — and a popup the keyboard closes (Left, Esc inside the menu) pops its level. KeyTipController.SyncWithPopups runs at the post-layout hook once no build is parked; each level records the surface it annotates (KeyTipLevel.Surface). A keyboard-opened popup that never realizes anything badgeable is left open (a drill's give-up still undoes its own reveal). (2) The QAT customize ▾ had no badge (a glyph face; its checklist is a raw Popup): it now carries the explicit '00' badge in the QAT's digit family and drills into the checklist. (3) A CheckBox's access-key reaction is focus-first by design (single- and multi-match consistent); a KeyTip badge names the box outright, so activating it now toggles through the click path (ButtonBase.InvokeKeyTipClick). KeyTipMenuNavigationTests. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013qbF5ru6uh5w7fqhP3yoPE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #72 (maintainer, 2026-09-12).
Badges follow the keyboard through menus. With the overlay up, a submenu the arrow keys open (Right/Enter on a header row) or a sibling top-level menu reached by arrows gets a level pushed over its rows; a popup the keyboard closes (Left, Esc inside the menu) pops its level. The rule: a newly opened popup whose placement target is one of the shown level's badged controls is a continuation of the drill.
KeyTipController.SyncWithPopupsruns at the post-layout hook once no build is parked, and each level records the surface it annotates. A keyboard-opened popup that never realizes anything badgeable is left open (only a drill's own give-up undoes its reveal).QAT customize ▾. It had no badge (a glyph face, and its checklist is a raw
Popuprather than a dropdown button). It now carries the explicit00badge in the QAT's digit family and drills into the checklist: the candidate check boxes, More Commands…, Show Below the Ribbon.Check boxes. The access-key reaction stays focus-first as designed (single- and multi-match consistent). A KeyTip badge names the box outright, so activating it toggles through the click path (
ButtonBase.InvokeKeyTipClick).Tests: new
KeyTipMenuNavigationTests(nested submenu via arrows, sibling menu via arrows, QAT customize drill + toggle). Bars 314 / UI 3962 green. Design doc §14 updated.🤖 Generated with Claude Code
https://claude.ai/code/session_013qbF5ru6uh5w7fqhP3yoPE