Skip to content

Fix contextual Tutor recovery privacy - #48

Merged
msrivas-7 merged 3 commits into
mainfrom
dev/contextual-recovery-closeout
Sep 1, 2026
Merged

Fix contextual Tutor recovery privacy#48
msrivas-7 merged 3 commits into
mainfrom
dev/contextual-recovery-closeout

Conversation

@msrivas-7

@msrivas-7 msrivas-7 commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Product change\n\n- Before: a responsive Tutor interruption followed by an admission outage could erase the deterministic error guide. Now: the guide remains through failed recovery, then retires after a successful ordinary Tutor answer.\n- Before: unexpected provider failures exposed raw JSON to learners. Now: the Tutor shows a private, useful recovery message and keeps ordinary Retry available.\n\n## Verification\n\n- Real local in-app browser: interruption → compact remount → admission refusal → ordinary recovery at 390×844; no overflow, raw error, stale guide, or focus loss\n- Frontend: 553/553 tests, typecheck, production build\n- Contextual E2E: Chromium + WebKit 38/38, retries disabled\n- Focused provider-error E2E: passed, retries disabled\n- Review fixes: cancellation is proven before route release; successful ordinary recovery now owns attention and retires the guide

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T08:53:14.088626Z 37ea349 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-48.eastus2.7.azurestaticapps.net

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37ea349e4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/src/features/learning/pages/LessonPage.tsx
Comment thread e2e/specs/contextual-guidance.spec.ts
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-48.eastus2.7.azurestaticapps.net

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-48.eastus2.7.azurestaticapps.net

@msrivas-7
msrivas-7 merged commit 4628d84 into main Sep 1, 2026
72 of 73 checks passed
@msrivas-7
msrivas-7 deleted the dev/contextual-recovery-closeout branch September 1, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant