ci: target a four-minute full PR quality loop - #47
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5adf6bdc62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Goal
Move normal full PR CI toward a 4-minute median / 5-minute p95 without removing tests, weakening browser/security coverage, relying on retries, or requiring paid runners.
Changes
User journey change
Before: a very fast Docker kill could occasionally leave Editor stuck on “Stopping this run…”.
Now: Stop always settles to “Run stopped,” restores Run, and the learner can execute again immediately.
Measured results
The two clean exact-head E2E samples have a 4m36s observed median, and both finish below five minutes. All 439 Chromium tests, the complete advisory critical lane, Firefox, WebKit, and every security scenario passed without retry dependence. Two samples do not establish a statistical p95; trusted clean history will continue measuring that target.
The first overlapping final-head E2E attempt exposed one transient bootstrap data-load failure and was not counted. Its retry passed, but the workflow remained red by design. The two complete reruns above then passed with zero flaky tests; no timeout, assertion, or retry policy was weakened.
Rejected experiments
Validation
Final gate
The exact final commit passed two complete clean 16/2 E2E runs, security, platform CI, and Codex review. After merge, timings will be verified again on main.