ci(e2e): benchmark build reuse and worker count - #45
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76fc7f2e41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-45.eastus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-45.eastus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-45.eastus2.7.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-45.eastus2.7.azurestaticapps.net |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What this PR does
Benchmark safeguards
The three immutable images build in parallel, and their complete build/publish critical path is charged to the reuse candidate. Reuse cannot win merely because its shard stage is faster. The benchmark remains at 16 shards per stage, while 20 is the hard ceiling so the normal PR's other jobs retain headroom under the account-wide concurrency limit.
CI isolation repair
The first ordinary run proved all Docker stacks shared one anonymous IP counter and collectively crossed the real 100-run daily cap. Each lane, shard, attempt, and benchmark stage now gets a deterministic reserved synthetic IPv6 address through the existing trusted Vite proxy. The quota remains enforced; unrelated jobs no longer consume one another’s allowance.
The worker benchmark also exposed a teardown-only socket failure after product assertions had passed. Session cleanup now treats transport loss during its best-effort drain consistently with the existing explicit cleanup path, while HTTP failures and product assertions remain unchanged.
Product journey impact
None. These are CI-only identities and measurements; production/local browser behavior, the complete Chromium suite, and Firefox/WebKit coverage remain unchanged.
Validation
X-Forwarded-Foridentity.Rollout
The measured winner is adopted: 16 shards, two workers, and build-once image reuse. Twenty remains only the account/topology ceiling. Failed runs retain their images for isolated reruns; successful runs clean immediately and the scheduled sweep bounds abandoned versions.