v2.5 Rewrite for Optimization & Less Dependencies - #8
Merged
Conversation
- Replace requests with stdlib urllib.request (redirects still blocked via a no-redirect handler); drop the post-validation URL rewriting in download_file that mangled an already-validated host - Drop bleach: SMS bodies are stored as plain .txt, never rendered as HTML, so tag-stripping bought nothing - Remove unused FaxData model, the SmsData dict wrapper (plain request.json() now, bad JSON returns 400 instead of 500), an unreachable AddressValueError handler, and a debug log that printed a literal string - Simplify on_confirmed to os.makedirs + shutil.move; move the directory creation there from send_fax where it was otherwise unused - Trim requirements.txt to direct deps (starlette/pydantic ship with FastAPI) - Dockerfile: drop no-op ENV TUNNEL_TOKEN (no matching ARG) and unused /etc/cloudflared mkdir
…d/bind mounted pathes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…pdate file handling in store_sms and FaxEventHandler. Addresses CodeQL scans in #8
…path so codeql stops freaking out about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.