Add a Sonarr/Radarr webhook that applies cached artwork when new media is imported#58
Draft
Thoroslives wants to merge 5 commits into
Draft
Add a Sonarr/Radarr webhook that applies cached artwork when new media is imported#58Thoroslives wants to merge 5 commits into
Thoroslives wants to merge 5 commits into
Conversation
Thoroslives
force-pushed
the
import-webhook-pr
branch
2 times, most recently
from
July 16, 2026 07:31
582c2e6 to
af94055
Compare
When ThePosterDB's upload counter overshoots the pages it lists, the crawl used to run on into empty pages; the parse error on those marked the crawl unclean, which blocked both the crawl-state record and the tombstone pass, so an affected user did a full crawl every run and never reconciled. Stop the crawl at the first page that fetches cleanly but lists nothing, and don't treat that empty page as a failure. Guard the tombstone pass so a full crawl that was cut short (a markup change parsing to zero posters) never deletes what it didn't reach: only reconcile when the crawl covered most of the user's reported uploads, and otherwise leave the full-crawl timestamp unset so the next run retries. Also surface how many new assets a run added to the cache.
Thoroslives
force-pushed
the
import-webhook-pr
branch
from
July 20, 2026 22:06
af94055 to
1780b7f
Compare
Contributor
Author
|
Rebased onto v0.8.8 for clean mergeability. |
… label _hydrate_from_cache built the artwork dicts that feed the upload processor with the key "type", but get_posters and the processor use "file_type". ARTWORK_ID_MAP.get(None) then returns None and PlexUploader.set_artwork does None + md5(url), raising "unsupported operand type(s) for +: NoneType and str". Latent until a cached crawl meets an unlocked in-library item. Regression test drives _hydrate_from_cache for real (the existing cache tests stub it out) and asserts every produced dict carries a file_type that ARTWORK_ID_MAP resolves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The import webhook's _artwork_dict keyed the artwork type as "type", but the upload processor reads "file_type" to resolve the Plex label prefix. It came out None and PlexUploader.set_artwork did None + md5(url), so every Radarr/ Sonarr import with cached artwork died with "unsupported operand type(s) for +: NoneType and str" (seen in production on a Disclosure Day (2026) import). Regression test builds the webhook artwork dict and runs it through the same label path the processor uses, asserting it no longer crashes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Blocked by #57. This webhook reads the cached user index that #57 adds, so please merge #57 first. Until then this PR's diff includes #57's commit; once #57 is merged I will rebase so it shows only the webhook changes.
With
cache_user_scrapesenabled (#57), the app already knows every poster your favourite ThePosterDB users have uploaded. This adds an opt-in webhook endpoint that Sonarr and Radarr can call when they import something, so a newly added movie or episode gets its artwork within a minute or so instead of waiting for the next scheduled run.On an import event the title is looked up in the cached index (you configure which users to apply from, in order of preference, first match wins); if one of them covers it, that single artwork is applied through exactly the same processing path as a normal scrape, so artwork labels, skips and Kometa asset mode all behave as usual, and nothing is fetched or applied when no cached artwork matches. Imports usually reach the webhook before Plex has scanned the new file, so there is a configurable delay before the first attempt plus a short retry, after which it gives up and leaves the item to the next scheduled run.
enable_webhooks(defaultfalse, so the endpoints return 404 when disabled),webhook_token(required; sent as anX-Webhook-Tokenheader, the connection's Basic password, or a?token=query parameter),webhook_tpdb_users, andwebhook_apply_delay(default 30 seconds) in config.json, plus a Webhook settings section in the web UIPOST /webhook/radarrandPOST /webhook/sonarr; the apps' Test button is acknowledged so the connection can be saved; only "On File Import" events do any work, everything else is acknowledged and ignoredtests/Depends on #57.