Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions example/src/NitroImageTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ export function NitroImageTab() {
numColumns={4}
windowSize={3}
data={imageURLs}
keyExtractor={(url) => url}
renderItem={({ item: url }) => (
<NitroImage
image={{ url: url }}
recyclingKey={url}
style={styles.image}
resizeMode="cover"
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package com.margelo.nitro.image

data class HybridImageLoadTicket(
val generation: Long,
val bindingKey: String
)
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,12 @@ class HybridImageLoader(

override fun requestImage(forView: HybridNitroImageViewSpec) {
val view = forView as? HybridImageView ?: return
val ticket = view.beginLoad(this) ?: return

loadImage().then { maybeImage ->
val image = maybeImage as? HybridImage ?: return@then
uiScope.launch {
view.imageView.setImageBitmap(image.bitmap)
view.applyLoadedBitmap(ticket, image.bitmap)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.margelo.nitro.image

import android.content.Context
import android.graphics.Bitmap
import android.util.Log
import android.view.View
import android.widget.ImageView
Expand All @@ -20,8 +21,12 @@ class HybridImageView(context: Context): HybridNitroImageViewSpec(), RecyclableV
}
private val uiScope = CoroutineScope(Dispatchers.Main.immediate)
private var resetImageBeforeLoad = false
private var isAttached = false
private var activeLoadTicket: HybridImageLoadTicket? = null
private var nextLoadGeneration = 0L

val imageView = CustomImageView(context) { visible ->
isAttached = visible
if (visible) onAppear()
else onDisappear()
}
Expand Down Expand Up @@ -51,7 +56,7 @@ class HybridImageView(context: Context): HybridNitroImageViewSpec(), RecyclableV

override fun prepareForRecycle() {
onDisappear()
imageView.setImageBitmap(null)
imageView.setImageDrawable(null)
}

private fun updateResizeMode() {
Expand All @@ -67,16 +72,18 @@ class HybridImageView(context: Context): HybridNitroImageViewSpec(), RecyclableV
private fun updateImage() {
image?.match(
{ actualImage: HybridImageSpec ->
// Image
clearActiveRequest()
if (actualImage is HybridImage) {
imageView.setImageBitmap(actualImage.bitmap)
} else {
throw Error("Image is a different type than HybridImage!")
}
},
{ _: HybridImageLoaderSpec ->
// ImageLoader
onAppear()
// Defer loader work until the view is attached to avoid offscreen requests.
if (isAttached) {
onAppear()
}
}
)
}
Expand All @@ -96,10 +103,51 @@ class HybridImageView(context: Context): HybridNitroImageViewSpec(), RecyclableV

private fun onDisappear() {
val imageLoader = image?.asSecondOrNull() ?: return
clearActiveRequest()
try {
imageLoader.dropImage(this)
} catch (e: Throwable) {
Log.e(TAG, "Failed to drop Image!", e)
}
}

fun beginLoad(imageLoader: HybridImageLoaderSpec): HybridImageLoadTicket? {
if (!isAttached) {
return null
}

val bindingKey = bindingKeyFor(imageLoader)
if (activeLoadTicket?.bindingKey == bindingKey) {
return null
}

val ticket = HybridImageLoadTicket(++nextLoadGeneration, bindingKey)
activeLoadTicket = ticket
return ticket
}

fun applyLoadedBitmap(
ticket: HybridImageLoadTicket,
bitmap: Bitmap
): Boolean {
if (!isAttached) {
return false
}

if (activeLoadTicket != ticket) {
return false
}

// Ignore async completions that belong to an older binding or a detached view.
imageView.setImageBitmap(bitmap)
return true
}

private fun clearActiveRequest() {
activeLoadTicket = null
}

private fun bindingKeyFor(imageLoader: HybridImageLoaderSpec): String {
return "${System.identityHashCode(imageLoader)}:${recyclingKey ?: "none"}"
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package com.margelo.nitro.web.image

import android.content.Context
import android.widget.ImageView
import coil3.ImageLoader
import coil3.dispose
import coil3.load
import com.margelo.nitro.core.Promise
import com.margelo.nitro.image.HybridImageView
import com.margelo.nitro.image.HybridImageSpec
import com.margelo.nitro.image.HybridImageLoaderSpec
import com.margelo.nitro.image.HybridNitroImageViewSpec
Expand All @@ -20,14 +21,16 @@ class HybridWebImageLoader(private val imageLoader: ImageLoader,
}

override fun requestImage(forView: HybridNitroImageViewSpec) {
val imageView = forView.view as? ImageView ?: return
val view = forView as? HybridImageView ?: return
if (view.beginLoad(this) == null) return

imageView.load(url, imageLoader) {
view.imageView.load(url, imageLoader) {
this.applyOptions(options)
}
}

override fun dropImage(forView: HybridNitroImageViewSpec) {
// Coil automatically handles recycling here - I _think_.
val view = forView as? HybridImageView ?: return
view.imageView.dispose()
}
}
Loading