Skip to content

Powershell on Windows support#84

Open
kmatt wants to merge 13 commits into
mroth:mainfrom
kmatt:powershell
Open

Powershell on Windows support#84
kmatt wants to merge 13 commits into
mroth:mainfrom
kmatt:powershell

Conversation

@kmatt

@kmatt kmatt commented Jul 11, 2024

Copy link
Copy Markdown

Building on work in #14:

  • Update Git wrapper script
  • Powershell status commands script
  • Documentation update

@mroth

mroth commented Jul 16, 2024

Copy link
Copy Markdown
Owner

Sorry for the delay in response I was OOO at a conference. This looks great! 🎉 Really appreciate the work here. ❤️ Do you have thoughts on how we can integrate the Powershell testing into the CI? (I also don't have a Windows machine to verify manually.)

@kmatt

kmatt commented Jul 16, 2024

Copy link
Copy Markdown
Author

@mroth Not sure on CI based tests yet. So far I have only run go test as in the Rakefile. On Windows 11:

> go test ./...
?       github.com/mroth/scmpuff        [no test files]
?       github.com/mroth/scmpuff/commands/exec  [no test files]
?       github.com/mroth/scmpuff/commands/intro [no test files]
ok      github.com/mroth/scmpuff/commands/expand        0.078s
ok      github.com/mroth/scmpuff/commands/inits 0.078s
ok      github.com/mroth/scmpuff/commands/internal/arguments    0.066s
ok      github.com/mroth/scmpuff/commands/status        0.071s

@mroth

mroth commented Jul 20, 2024

Copy link
Copy Markdown
Owner

I approved the PR running in CI, so you should be able to see the output there as well for integration tests now.

The integration tests are (unfortunately? fortunately?) currently all still implemented in Aruba with Ruby. You can see 867661a as an example of what it looked like to add another shell to the test grid (this was also the PR that added multi-shell support to integration tests).

A few changes there should be enough to get it to work locally -- I suspect there might then have to be some other changes in the GitHub Actions scripts to only run PS tests on Windows runners, etc, but that part should hopefully be straightforward.

@chipbite

Copy link
Copy Markdown

@kmatt : Rooting for this one! 👍 🏁

Would be great to have scmpuff in powershell.
I have junior devs that use powershell, that would benefit from having scmpuff.

@kmatt

kmatt commented Dec 23, 2025

Copy link
Copy Markdown
Author

@chipbite I changed companies, and no longer have a Windows machine to work with. At the time with this PR compiled in locally, scmpuff worked for me on Windows 10 and 11, IIRC with PowerShell 7.

What remains is the getting the Ruby / Aruba CI tests to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants