fix: 🐛 save imported images next to the note in notebook subfolders - #8
Merged
Merged
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

概要
<leader>niで画像をインポートすると常に notebook 直下に保存される一方、挿入される Markdown リンク()はノート自身のディレクトリを基準に解決される。ノートが notebook のサブフォルダ内にある場合、この2つの基準がズレてリンク切れになっていた。変更内容
lua/nb/core.luanotebook_of()と対になるfolder_of(filepath)を追加。ノートパスから notebook 内のサブフォルダパスを返す(直下なら nil、ネストにも対応)import_file()に任意引数folderを追加。指定時は notebook 直下ではなくそのサブフォルダにファイルをコピーする。git commit 対象パスも notebook ルート相対(folder/filename)に補正し、.gitの存在チェック(git_commit_async)は notebook ルートのまま維持lua/nb/ui.luaimport_image()で現在のバッファからfolder_of()を求め、import_file()に渡す戻り値の
final_filenameは常に bare なファイル名のままなので、リンク組み立て側()は変更不要。動作確認
stylua --check ./luacheck luaパス<leader>niを実行して確認:🤖 Generated with Claude Code