feat(google_cloudsql_postgres): allow configuring backup start time - #494
Merged
Merged
Conversation
Contributor
Release plan
|
bqbn
approved these changes
Sep 8, 2026
Contributor
Author
|
Thanks for the r+ @bqbn -- do you know if this can just be merged or if it need any kind of extra process (atlantis, for instance)? |
stevejalim
force-pushed
the
sjalim/cloudsql-postgres-backup-start-time
branch
2 times, most recently
from
September 9, 2026 08:40
396bd34 to
70cfecc
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The new backup_start_time input lacks validation for the documented HH:MM UTC format, which can lead to avoidable apply-time/provider errors.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new optional module input to control the Cloud SQL automated backup window start time for the primary instance, while preserving existing behavior when unset.
Changes:
- Introduces
backup_start_timeinput (defaults tonull) invariables.tf. - Wires
backup_start_timethrough tosettings.backup_configuration.start_timeon the primary Cloud SQL instance. - Documents the new input in the module README.
File summaries
| File | Description |
|---|---|
| google_cloudsql_postgres/variables.tf | Adds new backup_start_time variable (nullable string) for backup window configuration. |
| google_cloudsql_postgres/main.tf | Sets backup_configuration.start_time from the new variable. |
| google_cloudsql_postgres/README.md | Adds the new input to the documented inputs table. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adds an optional backup_start_time variable (HH:MM, UTC) that maps to the backup_configuration.start_time argument on the primary instance. Defaults to null, matching prior behavior where Cloud SQL picks a random start time, so this is a no-op for existing callers.
stevejalim
force-pushed
the
sjalim/cloudsql-postgres-backup-start-time
branch
from
September 9, 2026 08:51
70cfecc to
3316fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional backup_start_time variable (HH:MM, UTC) that maps to the backup_configuration.start_time argument on the primary instance.
Defaults to null, matching prior behavior where Cloud SQL picks a random start time, so this is a no-op for existing callers.