Skip to content

feat(google_cloudsql_postgres): allow configuring backup start time - #494

Merged
stevejalim merged 1 commit into
mainfrom
sjalim/cloudsql-postgres-backup-start-time
Sep 9, 2026
Merged

stevejalim merged 1 commit into
mainfrom
sjalim/cloudsql-postgres-backup-start-time

Conversation

@stevejalim

Copy link
Copy Markdown
Contributor

Adds an optional backup_start_time variable (HH:MM, UTC) that maps to the backup_configuration.start_time argument on the primary instance.

Defaults to null, matching prior behavior where Cloud SQL picks a random start time, so this is a no-op for existing callers.

@stevejalim
stevejalim requested a review from jbuck September 7, 2026 17:09
@github-actions github-actions Bot added the minor This PR will increment a minor version label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Release plan

Directory Previous version New version
google_cloudsql_postgres 0.9.0 0.10.0

@stevejalim

Copy link
Copy Markdown
Contributor Author

Thanks for the r+ @bqbn -- do you know if this can just be merged or if it need any kind of extra process (atlantis, for instance)?

@stevejalim
stevejalim force-pushed the sjalim/cloudsql-postgres-backup-start-time branch 2 times, most recently from 396bd34 to 70cfecc Compare September 9, 2026 08:40
@stevejalim
stevejalim requested a lite review from Copilot September 9, 2026 08:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new backup_start_time input lacks validation for the documented HH:MM UTC format, which can lead to avoidable apply-time/provider errors.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a new optional module input to control the Cloud SQL automated backup window start time for the primary instance, while preserving existing behavior when unset.

Changes:

  • Introduces backup_start_time input (defaults to null) in variables.tf.
  • Wires backup_start_time through to settings.backup_configuration.start_time on the primary Cloud SQL instance.
  • Documents the new input in the module README.
File summaries
File Description
google_cloudsql_postgres/variables.tf Adds new backup_start_time variable (nullable string) for backup window configuration.
google_cloudsql_postgres/main.tf Sets backup_configuration.start_time from the new variable.
google_cloudsql_postgres/README.md Adds the new input to the documented inputs table.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread google_cloudsql_postgres/variables.tf
Adds an optional backup_start_time variable (HH:MM, UTC) that maps to
the backup_configuration.start_time argument on the primary instance.

Defaults to null, matching prior behavior where Cloud SQL picks a
random start time, so this is a no-op for existing callers.
@stevejalim
stevejalim force-pushed the sjalim/cloudsql-postgres-backup-start-time branch from 70cfecc to 3316fa8 Compare September 9, 2026 08:51
@stevejalim
stevejalim merged commit 3c1a3ff into main Sep 9, 2026
10 checks passed
@stevejalim
stevejalim deleted the sjalim/cloudsql-postgres-backup-start-time branch September 9, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor This PR will increment a minor version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants