Handle 404 from Bugzilla user lookup in probe expiry alerts - #1075
Merged
Merged
Conversation
Bugzilla now returns HTTP 404 (still with error code 51) when a user does not exist. check_bugzilla_user_exists only handled 400, so the first probe with an alert email that has no Bugzilla account (passwords-dev@mozilla.org, PWMGR_IMPORT_LOGINS_FROM_FILE_CATEGORICAL expiring in 160) made probe-expiry-alerts fail with an unhandled HTTPError. The task has been failing daily since 2026-09-10. Treat code 51 as "user not found" for both 400 and 404, and cover both status codes in the test.
BenWu
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla now returns HTTP 404 (still with error code 51) when a user does not exist. check_bugzilla_user_exists only handled 400, so the first probe with an alert email that has no Bugzilla account (passwords-dev@mozilla.org, PWMGR_IMPORT_LOGINS_FROM_FILE_CATEGORICAL expiring in 160) made probe-expiry-alerts fail with an unhandled HTTPError. The task has been failing daily since 2026-09-10.
Treat code 51 as "user not found" for both 400 and 404, and cover both status codes in the test.