Sept 3rd Deploy - #1099
Merged
Merged
Conversation
* ⬆️ Update all npm dependencies (2026-07-28) * Fix @typescript-eslint/unbound-method errors in tests after typescript-eslint 8.65 bump --------- Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Carla Severe <csevere@mozilla.com>
* ⬆️ Update react-router to version 8.3.0
* ⬆️ Update react-router to version 8.3.0
* Transform ESM-only react-router 8 and cookie-es in jest
react-router 8 dropped its CommonJS build ("type": "module", no "require"
export condition), so jest loaded it as raw ESM and 27 of 32 suites failed
with "Cannot use import statement outside a module" — every suite that goes
through renderWithRouter in test-utils
---------
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Carla Severe <csevere@mozilla.com>
⬆️ Update all npm dependencies (2026-08-05) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…lues in explanations (#1077) bootstrap-ci: return null for <2 runs instead of a NaN CI BCa's acceleration uses a leave-one-out jackknife, which is undefined for a single observation (leaving it out gives an empty sample). A subtest with one run per side therefore produced a [NaN, NaN] median-difference interval. Return null below two runs per group and omit the interval in the Mann-Whitney blurb. Adds a regression test.
⬆️ Update all npm dependencies (2026-08-13) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…ecessary silverman_kde data (#1079) * Remove unused MannWhitneyResultsItem fields (backend cleanup) * Remove the silverman_kde feature (request param + response field)
removed silverman and kde warnings
… columns and display how to read the results (#1069) * Create simplified view and advanced column options Update tests too Adjust styles for new table changes created toggle for customizing col: simple vs power view update tests to reflect new UI/UX add interpret results panel for simple users render 0.00 vs - for no data in median col update table to include significance; add difference below status update how to read the results Add an "Advanced columns" dropdown with independent Cliff's Delta and CLES Hidden by default; the choice persists to localStorage. Available on both the main and subtests pages. Persist advanced-column selection in the URL resolved PR review comments Add sortable/filterable Magnitude column and widen the results table * resolved PR comments * Make Advanced Columns a native Select and move it into the inputs row * Move Significance to an advanced column and surface Noise in Status * resolved comments
⬆️ Update all npm dependencies (2026-08-20) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…to subtests page (#1083) reduce size of cols and link subtest pills to subtests page
…sage the same across pages (#1084) Make the Mann-Whitney-U warning banner dismissable
⬆️ Update all npm dependencies (2026-08-27) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Make shared results-table URLs reproduce the same view regardless of cookies * Preserve initialized marker and seeded params on all URL writes * lint fix * Preserve initialized marker and seeded params on the subtests search write The subtests search handler built its URL update from the memoized rawSearchParams snapshot rather than the live URL. Because that snapshot is captured at mount and never recomputes (updates go through history.replaceState with no re-render), a search-term change would overwrite the URL with the stale snapshot and drop params written out-of-band after mount — the `initialized` marker and cookie-seeded filter/sort — the very state that lets a shared URL supersede the recipient's cookies. Build the write from currentUrlParams() instead, mirroring the fix already applied to the main results page (ResultsTable). rawSearchParams is still used for the mount-time initial search term (reads are fine; only writes need the live URL). Adds a regression test that seeds a status filter from a cookie, then types a search term and asserts the search param is written while the initialized marker and filter_status survive. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…ow components (#1089) * Bug 2059830 - Simplified View: rename Advanced columns dropdown to Advanced options and add expanded-row option plumbing Rename the "Advanced columns" dropdown to "Advanced options" (AdvancedColumnsMenu -> AdvancedOptionsMenu) and give it two grouped sections: "Columns" (Cliff's Delta, CLES, Significance) and "Expanded row" (effect size & confidence intervals, mode analysis, statistics table, data warnings). Add the state plumbing for the expanded-row options, mirroring the columns feature: an ExpandedRowOptions type, an `advanced_expanded` URL param (expandedRowUrl util), the columnPrefs slice field + updateExpandedRow action, a useExpandedRowOptions selector hook, and a shared useSeedAdvancedOptionsFromUrl hook that seeds both params on mount. All options default off (the simplified view) and persist in the URL so shared links reproduce the selection. No expanded-row rendering changes yet; that lands in a follow-up commit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Bug 2059830 - Simplified View: move the density graph legend to the top and gate mode controls Move the Base/New legend from the middle of the chart to the top so the labels read as a header for the whole graph, and add 16px of spacing beneath it (with the scatter strip and overall height adjusted to match). Add an optional `showModeControls` prop to CommonGraph (default true, so Student-T is unaffected) that hides the mode-analysis controls (valley-depth slider + "Show modes" checkbox) as a unit. The Mann-Whitney-U simplified view uses it to keep those controls out of the default view until the "Mode analysis" expanded-row option is enabled. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Bug 2059830 - Simplified View: simplified Mann-Whitney-U expanded row Restructure the Mann-Whitney-U expanded row into a simplified default view: a full-width density graph with a how-to-read blurb plus the always-on summary (platform, single-run note, Base/New application, comparison result). The heavier statistical components are opt-in via the "Advanced options -> Expanded row" checkboxes. - Lay the four opt-in components out in a two-column grid below the graph (effect size + mode analysis on one row, statistics table + data warnings on the next) rather than stacking them full-width; the stats table and warnings fill their cell (dropped hard-coded 85%/55% widths). - Gate the mode-analysis controls and on-chart overlays behind the "Mode analysis" option (via CommonGraph's showModeControls) so they're absent from the default view. - Show a "No mode analysis available" placeholder when Mode analysis is on but the comparison yields no mode breakdown, so the cell isn't left empty. - Drop the now-unused options plumbing from the strategy's renderExpandedBottom (the components are rendered directly by the expanded grid). Student-T is untouched. Adds coverage for the default hidden state, per-option reveals, the mode-controls gating, and the empty-state placeholder. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * reduce CLES col width * update snapshots * address review comments --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* show blurb as tooltip over info icon * remove tooltip, keep dropdown from changing width, and remove ghost highlight * keep modes in simple view * move info icon closer to graph title and increase title font size Also give user feedback when they add comps to the expanded row in a zoomed-in view. * toasts tweaks and clean up verbose comments
⬆️ Update all npm dependencies (2026-09-03) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Bumps [postcss-selector-parser](https://github.com/postcss/postcss-selector-parser) from 7.1.0 to 7.1.6. - [Release notes](https://github.com/postcss/postcss-selector-parser/releases) - [Changelog](https://github.com/postcss/postcss-selector-parser/blob/main/CHANGELOG.md) - [Commits](postcss/postcss-selector-parser@v7.1.0...7.1.6) --- updated-dependencies: - dependency-name: postcss-selector-parser dependency-version: 7.1.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kala-moz
requested review from
beatrice-acasandrei,
canova and
esanuandra
as code owners
September 3, 2026 18:14
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights:
[kala-moz]
Bug 2068296 Simplified View Follow up for expanded view (#1094)
Bug 2059830 Simplified View: Create checkbox selection for expanded row components (#1089)
Bug 2058240: Filters from cookies don't make it into the URL (#1076)
Bug 2059826 - Simplified View: Create checkbox selection for advanced columns and display how to read the results #1069
Simplified View Follow-up: reduce size of cols and link subtest pills to subtests page (#1083)
Other changes:
[kala-moz]
Removed silverman and kde warnings (#1082)
Bug 2059493: Clean up components in perfcompare frontend using the unecessary silverman_kde data (#1079)
Fix for Bug 2060613: PerfCompare statistical analysis has some NaN values in explanations (#1077)
[gopar]
bug-2021092[] Update light/dark toggle wording to be less ambiguous (#1073)