branches: add esr branch support (bug 2048638) - #2198
Conversation
|
Coverage is 90.782% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
3 similar comments
|
Coverage is 90.782% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
|
Coverage is 90.782% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
|
Coverage is 90.782% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
|
Coverage is 90.997% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
3 similar comments
|
Coverage is 90.997% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
|
Coverage is 90.997% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
|
Coverage is 90.997% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
|
Coverage is 90.948% — magnolia/bug2048638-add-esr-branch-support into main. No base build found for |
comm-central uses nightly path, not taskcluster.
| return self._branches[self.get_name(branch_name_or_alias)] | ||
| return self._branches[name] | ||
| except KeyError: | ||
| if RE_ESR.match(name): |
There was a problem hiding this comment.
This check is repeated a few times in this class. We could put this functionality in self._esr_match and self.is_esr_name.
| if branch_name_or_alias: | ||
| match = RE_ESR.match(branch_name_or_alias) |
There was a problem hiding this comment.
nit
| if branch_name_or_alias: | |
| match = RE_ESR.match(branch_name_or_alias) | |
| if branch_name_or_alias and match := RE_ESR.match(branch_name_or_alias): |
Then later lines can be dedented.
| elif self.app_name == "firefox" and is_esr: | ||
| self.repo = "mozilla-" + name | ||
| elif is_esr: | ||
| # A bare `esr` defaults to the Firefox (`mozilla`) repository. | ||
| self.repo = "mozilla-" + name |
There was a problem hiding this comment.
nit - I don't think adding the check for self.app_name == "firefox" is doing anything here.
| elif self.app_name == "firefox" and is_esr: | |
| self.repo = "mozilla-" + name | |
| elif is_esr: | |
| # A bare `esr` defaults to the Firefox (`mozilla`) repository. | |
| self.repo = "mozilla-" + name | |
| elif is_esr: | |
| # A bare `esr` defaults to the Firefox (`mozilla`) repository. | |
| self.repo = "mozilla-" + name |
| if repo: | ||
| name = branches.get_name(repo) | ||
| is_esr = name.startswith("esr") |
There was a problem hiding this comment.
I think it would be better to reverse the logic here. Handle the general case first, and then handle the esr case.
4 participants
This change makes the CLI + GUI recognize the mozilla-esr / comm-esr / esr pattern and construct the hg repo URL dynamically.
Resolution is a blind HTTP fetch: we build the URL from whatever version the user passes and request it. If that ESR exists on hg the fetch is a hit and bisection proceeds. If it doesn't, the request simply misses and the branch is treated as unavailable.
Previously, mozregression was not working as expected since it could not find any builds when using commands like
mozregression --app thunderbird --repo comm-releasefor Thunderbird branches other than comm-central. This was because comm-esr, comm-release, and comm-beta don't have opt builds, they only have shippable ones.Fix the behaviour for fetching integration builds both for comm-esr branches and other comm branches by implementing similar behaviour as existing tk_routes construction in Firefox.
Add small help text that shows how to fetch ESR branches as they will not show up in the drop down menu.
New UI:
