Conversation
simd/CMakeLists.txt still tests ENABLE_SHARED, which no longer exists: the top level now uses BUILD_SHARED_LIBS (default TRUE). The condition is always false, so the simd objects are built without -fPIC and linking libjpeg.so fails on x86_64: relocation R_X86_64_TPOFF32 against `simd_support' can not be used when making a shared object This breaks a default cmake && make on a fresh clone (issue mozilla#449).
ENABLE_STATIC was removed along with ENABLE_SHARED, so the guard is always true and WITH_FUZZ=1 aborts at configure time. The fuzz targets link jpeg-static and turbojpeg-static, which exist when BUILD_SHARED_LIBS is off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simd/CMakeLists.txtandfuzz/CMakeLists.txtstill testENABLE_SHARED/ENABLE_STATIC, which no longer exist — the top level usesBUILD_SHARED_LIBS(default
TRUE), so both conditions are dead.simd: no
-fPICon the objects, no-DPICfor NASM, so linkinglibjpeg.sofails on x86_64 —static __thread simd_supportgets local-execTLS relocations:
This breaks a plain
cmake && makeon a fresh clone. Fixes #449.fuzz:
if(NOT ENABLE_STATIC)is always true, so-DWITH_FUZZ=1aborts atconfigure even with
-DBUILD_SHARED_LIBS=OFF.libjpeg-turbo defines
ENABLE_SHAREDitself, so the rename is mozjpeg-only.Verified on Ubuntu 26.04 / gcc 15.2 / nasm 3.01: default build links,
cjpeg/djpeg round-trip OK.