Skip to content

mozanalysis's DataSource should wrap metric-config-parser's DataSource instead of almost duplicating the functionality #293

Description

@danielkberry

As discussed here, mozanalysis's DataSource object contains an almost identical set of parameters as metric-config-parser's DataSource. This leads to the need for converter methods (example) and unnecessary confusion over objects. I propose replacing mozanalysis's DataSource object with something like:

from metric_config_parser import DataSource
from mozanalysis.types import AnalysisUnit

class ExperimentDataSource:
  data_source: DataSource
  app_id: str
  analysis_unit: AnalysisUnit

  def build_query(self, ...) -> str:
     ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions