chore(auth): replace axios with fetch in third-party auth routes #20729
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import jwt from 'jsonwebtoken'; | ||
| import { getApplePublicKey, getGooglePublicKey } from './third-party-events'; | ||
|
|
||
| jest.mock('jsonwebtoken', () => ({ | ||
| decode: jest.fn(), | ||
| verify: jest.fn(), | ||
| })); | ||
|
|
||
| jest.mock('@fxa/shared/pem-jwk', () => ({ | ||
| jwk2pem: jest.fn(() => 'fake-pem'), | ||
| })); | ||
|
|
||
| describe('third-party-events public key fetching', () => { | ||
|
|
||
| let statsd: any; | ||
| let originalFetch: typeof global.fetch; | ||
|
|
||
| beforeEach(() => { | ||
| statsd = { increment: jest.fn() }; | ||
| originalFetch = global.fetch; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| global.fetch = originalFetch; | ||
| }); | ||
|
|
||
| describe('getApplePublicKey', () => { | ||
| it('returns the pem for the key matching the token kid', async () => { | ||
| (jwt.decode as jest.Mock).mockReturnValue({ | ||
| header: { kid: 'apple-kid' }, | ||
| }); | ||
| global.fetch = jest.fn().mockResolvedValue({ | ||
| ok: true, | ||
| json: async () => ({ keys: [{ kid: 'apple-kid', n: 'x', e: 'AQAB' }] }), | ||
| } as unknown as Response); | ||
|
|
||
| const result = await getApplePublicKey('token', statsd); | ||
|
|
||
| expect(result).toEqual({ pem: 'fake-pem' }); | ||
| }); | ||
|
|
||
| it('throws and increments statsd when the key endpoint responds non-ok', async () => { | ||
| global.fetch = jest | ||
| .fn() | ||
| .mockResolvedValue({ ok: false, status: 503 } as unknown as Response); | ||
|
|
||
| await expect(getApplePublicKey('token', statsd)).rejects.toThrow( | ||
| 'Failed to get Apple public key' | ||
| ); | ||
| expect(statsd.increment).toHaveBeenCalledWith('getApplePublicKey.error'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getGooglePublicKey', () => { | ||
| it('returns the pem and issuer for the key matching the token kid', async () => { | ||
| (jwt.decode as jest.Mock).mockReturnValue({ | ||
| header: { kid: 'google-kid' }, | ||
| }); | ||
| global.fetch = jest | ||
| .fn() | ||
| .mockResolvedValueOnce({ | ||
| ok: true, | ||
| json: async () => ({ | ||
| jwks_uri: 'https://example.com/jwks', | ||
| issuer: 'https://accounts.google.com', | ||
| }), | ||
| } as unknown as Response) | ||
| .mockResolvedValueOnce({ | ||
| ok: true, | ||
| json: async () => ({ | ||
| keys: [{ kid: 'google-kid', n: 'x', e: 'AQAB' }], | ||
| }), | ||
| } as unknown as Response); | ||
|
|
||
| const result = await getGooglePublicKey('token', statsd); | ||
|
|
||
| expect(result).toEqual({ | ||
| pem: 'fake-pem', | ||
| issuer: 'https://accounts.google.com', | ||
| }); | ||
| }); | ||
|
|
||
| it('throws and increments statsd when the RISC config endpoint responds non-ok', async () => { | ||
| global.fetch = jest | ||
| .fn() | ||
| .mockResolvedValue({ ok: false, status: 500 } as unknown as Response); | ||
|
|
||
| await expect(getGooglePublicKey('token', statsd)).rejects.toThrow( | ||
| 'Failed to get Google public key' | ||
| ); | ||
| expect(statsd.increment).toHaveBeenCalledWith('getGooglePublicKey.error'); | ||
| }); | ||
|
|
||
| it('throws when the jwks endpoint responds non-ok', async () => { | ||
| global.fetch = jest | ||
| .fn() | ||
| .mockResolvedValueOnce({ | ||
| ok: true, | ||
| json: async () => ({ | ||
| jwks_uri: 'https://example.com/jwks', | ||
| issuer: 'https://accounts.google.com', | ||
| }), | ||
| } as unknown as Response) | ||
| .mockResolvedValueOnce({ | ||
| ok: false, | ||
| status: 502, | ||
| } as unknown as Response); | ||
|
|
||
| await expect(getGooglePublicKey('token', statsd)).rejects.toThrow( | ||
| 'Failed to get Google public key' | ||
| ); | ||
| expect(statsd.increment).toHaveBeenCalledWith('getGooglePublicKey.error'); | ||
| }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the request identical to what axios previously sent: turn the plain object into a JSON body with
application/jsonheader.