Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a simple NestJS authentication guard to the entitlements/metering library to validate incoming Authorization: Bearer <token> requests against configured client secrets, and wires the guard/config into the Payments API module for DI.
Changes:
- Introduces
MeteringAuthGuard, aCurrentMeteringClientparam decorator, and request attachment helpers. - Adds a reusable
extractBearerTokenutility with unit tests. - Exports the new guard/util from
@fxa/entitlements/meteringand registers guard/config providers in Payments API.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/entitlements/metering/src/lib/utils/extractBearerToken.ts | Adds bearer-token parsing helper used by the guard. |
| libs/entitlements/metering/src/lib/utils/extractBearerToken.spec.ts | Unit tests for bearer-token parsing behavior. |
| libs/entitlements/metering/src/lib/metering-auth.guard.ts | Adds NestJS guard + request/decorator plumbing for metering client auth. |
| libs/entitlements/metering/src/lib/metering-auth.guard.spec.ts | Unit tests for guard construction and authorization behavior. |
| libs/entitlements/metering/src/index.ts | Exports the new guard and token utility from the package entrypoint. |
| apps/payments/api/src/app/app.module.ts | Registers metering guard/config in the Payments API module providers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Because: - We want a simple NestJS guard to validate incoming requests This commit: - Adds an auth guard Closes ENT-21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes ENT-21