Skip to content

polish(settings): Fail fast if client info look up fails#20721

Open
dschom wants to merge 1 commit into
mainfrom
fail-fast-if-client-info-look-up-fails
Open

polish(settings): Fail fast if client info look up fails#20721
dschom wants to merge 1 commit into
mainfrom
fail-fast-if-client-info-look-up-fails

Conversation

@dschom

@dschom dschom commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Because

  • We should fail early if client info fail to resolve correctly and the client info state is bogus.

This pull request

  • Shows an error screen if something goes sideways.

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner June 10, 2026 01:25
@dschom dschom changed the title Fail fast if client info look up fails polish(settings): Fail fast if client info look up fails Jun 10, 2026
@dschom dschom force-pushed the fail-fast-if-client-info-look-up-fails branch 4 times, most recently from 299e499 to 4daee69 Compare June 11, 2026 16:19
@dschom dschom force-pushed the fail-fast-if-client-info-look-up-fails branch from 4daee69 to 639a6d8 Compare June 11, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants