Conversation
44d0ecd to
ee40cce
Compare
dschom
reviewed
Jun 10, 2026
| const timerRef = useRef<ReturnType<typeof setTimeout>>(); | ||
|
|
||
| const startThrottle = useCallback((error: ThrottleErrorInput) => { | ||
| const retryAfterMs = error?.retryAfter ?? 0; |
Contributor
There was a problem hiding this comment.
Why error?, shouldn't this be error. An undefined or null value isn't allowed.
dschom
reviewed
Jun 10, 2026
| clearTimeout(timerRef.current); | ||
| setIsThrottled(true); | ||
| timerRef.current = setTimeout(() => setIsThrottled(false), retryAfterMs); | ||
| }, []); |
Contributor
There was a problem hiding this comment.
Should this really be empty?
Contributor
Author
There was a problem hiding this comment.
Yea, the values inside are either passed in params or stable, so there's nothing reactive.
dschom
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
useThrottleCountdownhook that counts downretryAfterseconds, or stays throttled when onlyretryAfterLocalizedis present.throttleSecondsRemainingandthrottleLocalizedFallbackprops toFormVerifyCode. The submit button is disabled while throttled, and anaria-live="polite"region shows "Try again in N seconds".SigninTokenCode,SigninPasswordlessCode, andConfirmSignupCodeon their THROTTLED branches, and disables each page's "Email new code" button for the same window.form-verify-code-throttled-countdownandform-verify-code-throttled-generic.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-13742
Checklist
Put an
xin the boxes that apply