Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

fix(totp): replace recovery codes keyboard accessibility#7090

Open
karansapolia wants to merge 1 commit into
mozilla:masterfrom
karansapolia:fix-6593
Open

fix(totp): replace recovery codes keyboard accessibility#7090
karansapolia wants to merge 1 commit into
mozilla:masterfrom
karansapolia:fix-6593

Conversation

@karansapolia

Copy link
Copy Markdown
Contributor

Make 'Replace recovery codes' link keyboard accessible.
Add ability for tab indexing through link and pressing enter
to click on link.

fixes: #6593
@ryanfeeley Would request you to review.

@karansapolia

Copy link
Copy Markdown
Contributor Author

For reference, with keyboard accessibility working:
keyboardAccessible

@shane-tomlinson

Copy link
Copy Markdown

@vbudhram - could you review this?

@vbudhram vbudhram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karansapolia Thanks for the PR, I think a better solution in this scenario is to use a button instead of a link. You will need to style the button to look like a link though. By doing this you can remove the href tag.

@karansapolia

karansapolia commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

@karansapolia Thanks for the PR, I think a better solution in this scenario is to use a button instead of a link. You will need to style the button to look like a link though. By doing this you can remove the href tag.

Oh alright, let me do that and update the PR.

@karansapolia

Copy link
Copy Markdown
Contributor Author

@vbudhram have made the requested changes. review please.

@vbudhram vbudhram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karansapolia This is almost there! Just a couple minor things.

Comment thread app/styles/_base.scss Outdated
Comment thread app/styles/_base.scss
Make 'Replace recovery codes' keyboard accessible.
Replace earlier used link with button element to allow
tab indexing and keyboard click events for keyboard
accessibility.

fixes: #6593
@karansapolia

Copy link
Copy Markdown
Contributor Author

@vbudhram review please.

@shane-tomlinson

Copy link
Copy Markdown

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants