chore: update ws to 8.21.0, vitest to 4.1.8#90
Conversation
juliandescottes
left a comment
There was a problem hiding this comment.
@westurner thanks for the PR, the CI job is failing, can you update package-lock.json as well? Thanks
Fixes this error message: ``` ws 8.0.0 - 8.20.0 Severity: moderate ws: Uninitialized memory disclosure - GHSA-58qx-3vcg-4xpx No fix available node_modules/@mozilla/firefox-devtools-mcp/node_modules/ws @mozilla/firefox-devtools-mcp * Depends on vulnerable versions of ws node_modules/@mozilla/firefox-devtools-mcp 2 moderate severity vulnerabilities Some issues need review, and may require choosing a different dependency. ```
….8 per `npm audit fix --force`
|
@juliandescottes updated package-lock.json. And then |
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks, can you remove the carets from the versions?
|
Someday also:
|
There is one already, but yes it could mention the policy about version numbers. The tests are failing, I guess it's because of the vitest update, can you take a look? |
|
Had a quick look, should just require to migrate mocks in core-prefs.test.ts (https://github.com/mozilla/firefox-devtools-mcp/blob/main/tests/firefox/core-prefs.test.ts#L25-L50) and core.test.ts (https://github.com/mozilla/firefox-devtools-mcp/blob/main/tests/firefox/core.test.ts#L95-L118) to use classes for Options, ServiceBuilder and Builder. |
Fixes this error message: