bitflags: allow parsing unnamed ("_") bitflags#1169
Merged
Conversation
To avoid potentially truncating unknown bits within the derived methods, the documentation recommends adding an unnamed flag with all bits set. This commit allows cbindgen to parse those flags without throwing an error (like it did previously).
emilio
approved these changes
Jul 10, 2026
emilio
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid potentially truncating unknown bits within the derived methods, the documentation recommends adding an unnamed flag with all bits set. This commit allows cbindgen to skip parsing those flags without throwing an error (like it did previously, then skipping the entire item!), and only emit the named flags with values.
Before:
After:
I'm unsure if
unraw()would be needed due to my use of theIdentExt::parse_any, might be worth adding as a test case?And in order to pass
cargo clippywith yesterday's Stable release (1.97.0), I had to do another commit with some fixes. Let me know if you'd prefer a cleaner history.