macOS: notify about already-connected devices at the same time#363
Open
micolous wants to merge 1 commit into
Open
macOS: notify about already-connected devices at the same time#363micolous wants to merge 1 commit into
micolous wants to merge 1 commit into
Conversation
… and notify about all existing devices at the same time (mozilla#362)
jschanck
reviewed
Jul 13, 2026
| return Vec::with_capacity(0); | ||
| } | ||
|
|
||
| let s: CFSet<IOHIDDeviceRef> = CFSet::wrap_under_get_rule(devices); |
Collaborator
There was a problem hiding this comment.
Since IOHIDManagerCopyDevices has Copy in the name, we need to use CFSet::wrap_under_create_rule here to avoid a leak.
| } | ||
|
|
||
| /// Get all currently-connected devices. | ||
| fn get_devices(&mut self) -> Vec<IOHIDDeviceRef> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362, unblocks #315
This calls
IOHIDManagerCopyDevicesbefore starting theCFRunLoopforIOHIDManager, so that there is a singleDevicesAddedevent containing all already-connected devices, much like you'd get on Linux. If there are zero connected devices, then it's effecttivelyDevicesAdded(vec![]).This addresses a potential race condition if
IOHIDManageris slow to notify about a device which is already connected.IOHIDManagerstill callsDeviceMatchingCallbackfor every already-connected device once aCFRunLoophas started, so this also ignores duplicate events.