Skip to content
This repository was archived by the owner on May 28, 2026. It is now read-only.

chore(deps): upgrade example apps to clear security alerts - #176

Merged
Almaju merged 2 commits into
mozilla-services:mainfrom
Almaju:chore/security-upgrades
May 26, 2026
Merged

Almaju merged 2 commits into
mozilla-services:mainfrom
Almaju:chore/security-upgrades

Conversation

@Almaju

@Almaju Almaju commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps the example apps' dependencies to clear the open dependabot security alerts. Both example apps are dev-only and not shipped to consumers of @mozilla/majc, but the alerts are still worth clearing for hygiene.

examples/react

  • next 15.4.10 → 15.5.18 (latest 15.x backport). Clears the high-severity Next.js advisories (middleware bypass, server-component DoS, SSRF, etc.) that have 15.x fixes.
  • postcss ^8 → ^8.5.10 (fixes GHSA-qx2v-qp2m-jg93 — XSS via unescaped </style>).
  • Added overrides so next's nested postcss resolves to the fixed top-level version too.
  • next-env.d.ts was regenerated by next build (15.5+ adds a routes.d.ts triple-slash reference — auto-managed by Next).

examples/iife

  • package-lock.json regenerated. http-server@14.1.1 (already latest) now resolves to qs@6.15.2 and follow-redirects@1.16.0, both of which contain the fixed versions for the open advisories. lodash is no longer in the dep tree.

Not addressed by this PR

  • Two medium-sev Next.js advisories (HTTP request smuggling in rewrites, unbounded next/image disk cache growth) are only patched in next 16.x. Bumping to 16 was tested and broke the example's Turbopack-based build because Turbopack doesn't honor the tsconfig.json paths alias for @mozilla/majc/*. Worth a follow-up but out of scope here.
  • uuid advisory on the root lockfile (GHSA-w5hq-g745-h8pq) only affects v3()/v5()/v6(). This repo uses only v4() (single import in packages/core/src/store.ts), so the code path is not vulnerable. Recommend dismissing the alert manually.

Test plan

  • npm install && npm test in repo root — 20/20 suites, 102/102 tests, 100% coverage
  • npm run build in repo root — clean
  • npm run lint in repo root — clean
  • cd examples/react && npm install && npm audit — 0 vulnerabilities
  • cd examples/react && npm run build — clean
  • cd examples/iife && npm install && npm audit — 0 vulnerabilities

examples/react:
- Bump next 15.4.10 → 15.5.18 (latest 15.x backport). Clears all
  high-severity Next.js advisories with 15.x fixes.
- Bump postcss devDep to ^8.5.10 (PostCSS XSS CVE GHSA-qx2v-qp2m-jg93)
  and add an overrides entry so next's nested postcss resolves to the
  fixed version too.
- next-env.d.ts regenerated by next 15.5+ (adds routes.d.ts reference).

examples/iife:
- Regenerate package-lock.json. http-server@14.1.1 (already latest) now
  resolves to qs@6.15.2 and follow-redirects@1.16.0, both of which
  contain the fixed versions for the open advisories. lodash is no
  longer in the dep tree.

Not addressed by this PR:
- Two medium-sev next/image and rewrites advisories that are only
  patched in next 16.x. Bumping to next 16 breaks Turbopack tsconfig
  paths resolution for the example's @mozilla/majc/* alias, so deferred.
- uuid advisory on the root lockfile only affects v3/v5/v6; this repo
  uses only v4 in packages/core/src/store.ts, so the code path is not
  vulnerable. Will be dismissed separately.
@Almaju
Almaju requested a review from a team as a code owner May 26, 2026 00:23
next 15.5+ adds a triple-slash routes.d.ts reference to next-env.d.ts,
which conflicts with @typescript-eslint/triple-slash-reference. The
Next.js docs say not to edit next-env.d.ts, so exclude it from lint.
@Almaju
Almaju merged commit 74cfcc0 into mozilla-services:main May 26, 2026
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants