Bug 2000191: fix intermittent test failure caused by race condition.#243
Open
pollym wants to merge 1 commit intomozilla-firefox:autolandfrom
Open
Bug 2000191: fix intermittent test failure caused by race condition.#243pollym wants to merge 1 commit intomozilla-firefox:autolandfrom
pollym wants to merge 1 commit intomozilla-firefox:autolandfrom
Conversation
Root cause: Bug 1879332 changed `TabSessionState.isActive()` to use `maxOf(lastAccess, createdAt)`. Since createTab() defaulted `createdAt = System.currentTimeMillis()`, newly created test tabs have createdAt ≈ now. With `maxActiveTime = 0`, the check `now - createdAt <= 0` only returns false when at least 1ms has elapsed, making the result dependent on test execution speed. Fix: Pass `createdAt = lastAccess` to all `createTab()` calls in tests that use `maxActiveTime = 0` and expect `inactive = true`. Since lastAccess values like 123L are epoch-old timestamps, `now - maxOf(123L, 123L)` is always a large positive number, so `isActive(0)` deterministically returns `false` regardless of when the test runs.
Contributor
|
View this pull request in Lando to land it once approved. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: Bug 1879332 changed
TabSessionState.isActive()to usemaxOf(lastAccess, createdAt).Since createTab() defaulted
createdAt = System.currentTimeMillis(), newly created test tabs have createdAt ≈ now.With
maxActiveTime = 0, the checknow - createdAt <= 0only returns false when at least 1ms has elapsed, making the result dependent on test execution speed.Fix: Pass
createdAt = lastAccessto allcreateTab()calls in tests that usemaxActiveTime = 0and expectinactive = true.Since lastAccess values like 123L are epoch-old timestamps,
now - maxOf(123L, 123L)is always a large positive number, soisActive(0)deterministically returnsfalseregardless of when the test runs.