Bug 2057235 - Remove XMLRPC API support - #2678
Open
Xzzz wants to merge 1 commit into
Open
Conversation
Removes xmlrpc.cgi and Bugzilla/WebService/Server/XMLRPC.pm as well as support for the USAGE_MODE_XMLRPC and ERROR_MODE_DIE_SOAP_FAULT modes, the dependencies of the xmlrpc feature (SOAP::Lite, XMLRPC::Lite), the xmlrpc_* error codes and obsolete XML-RPC references in docs/POD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes xmlrpc.cgi and Bugzilla/WebService/Server/XMLRPC.pm as well as support for the USAGE_MODE_XMLRPC and ERROR_MODE_DIE_SOAP_FAULT modes, the dependencies of the xmlrpc feature (SOAP::Lite, XMLRPC::Lite), the xmlrpc_* error codes and obsolete XML-RPC references in docs/POD.
This is the first of a small set of child bugs cleaning up the old API surface, see 1599274 for details.
Changes
Deleted
xmlrpc.cgi- the XML-RPC entry-point scriptBugzilla/WebService/Server/XMLRPC.pm- the XML-RPC server implementationCore dispatch/constants
Bugzilla.pm- removed theUSAGE_MODE_XMLRPCbranch inusage_mode(), removedxmlrpc.cgiscript-name detection and updated POD examplesBugzilla/Constants.pm- removed theUSAGE_MODE_XMLRPCandERROR_MODE_DIE_SOAP_FAULTconstants and their exportsBugzilla/Util.pm- removed the XML-RPC check fromi_am_webservice()and updated PODBugzilla/Error.pm- removed theERROR_MODE_DIE_SOAP_FAULTbranchWebService layer
Bugzilla/WebService/Bug.pm- simplifiedcount_onlyhandling (dead XML-RPC branch removed)Bugzilla/WebService/Constants.pm- removedxmlrpc_invalid_value/xmlrpc_illegal_content_typeerror codes and the now-unusedXMLRPC_CONTENT_TYPE_WHITELISTconstantBugzilla/WebService.pm,Bugzilla/WebService/Server.pm,Bugzilla/WebService/Server/JSONRPC.pm,Bugzilla/WebService/Server/REST.pm- removed stale XML-RPC references from POD and comments (JSONRPC's POD now points to REST as the stable alternative)Bugzilla/WebService/{Bugzilla,BugUserLastVisit,Classification,Group,Product,User}.pm,extensions/Review/lib/WebService.pm- removed XML-RPC references from PODDependencies
Makefile.PL- removed thexmlrpcoptional-feature block (SOAP::Lite,XMLRPC::Lite,Test::Taintrequirement)Bugzilla/Install/Requirements.pm- removed thexmlrpcentry fromFEATURE_FILES(used byt/001compile.t)cpanfile- removed the unconditionalSOAP::LiteandXMLRPC::LiterequiresTemplates
template/en/default/global/user-error.html.tmpl- removed the two XML-RPC-only error message blockstemplate/en/default/admin/params/admin.html.tmpl- removed "XML-RPC" from a param descriptionTest plan
prove t/001compile.txmlrpc.cginow 404sReference