Enchance/simplify docker - #59
Merged
Merged
Conversation
LayNoah
reviewed
Aug 26, 2026
| HOST_UID=$$(id -u admin); HOST_GID=$$(id -g admin); fi && \ | ||
| echo ====== Map admin to host $$HOST_UID:$$HOST_GID ======= && \ | ||
| if [ \"$$HOST_GID\" != \"$$(id -g admin)\" ]; then \ | ||
| sudo groupmod -g $$HOST_GID admin \ |
Contributor
There was a problem hiding this comment.
Most change is great to me.
For this line, I'm hard to grasp the benefits than mapping ENV directly.
Could you introduce the intuition for this change?
It may be related to error checking, but I'm hard to imagine which error can be occurred.
# Convention way
environment:
- HOST_USER_GID=${HOST_USER_GID}
Contributor
Author
There was a problem hiding this comment.
Just reducing the user modification step for ~/.bashrc. Also, it is better for the user not to modify .env
LayNoah
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.