Repository navigation
Add start depth for pocket operations - #157
Open
DarkBiscuits wants to merge 1 commit into
Open
DarkBiscuits wants to merge 1 commit into
DarkBiscuits wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #88.
Adds optional
start_depthtocampanion-job/1pocket operations, measured downward from the original stock surface in job units. Forstart_depth: 3,depth: 8andstep_down: 2, pocket passes cut at Z -5, -7 and -8. The final depth retains its existing meaning. Omitting the field or setting it to zero preserves existing output; other operation kinds reject it.Both pocket area passes and wall-finishing passes use the remaining depth interval. Floor stock and onion skins stay referenced to the original final floor. Invalid starts, starts at or below the roughing stop, and excessive remaining pass counts are rejected. Finishing-only continuation is outside this scope.
Clearance and retract heights stay unchanged. Plunge, ramp and helix entries still feed from the configured retract height, with entry-angle and fit checks preserved. The caller must ensure the pocket area has already been cleared to
start_depth; this field does not infer remaining stock or add rapids below the retract height.Validation:
scripts/check.shpasses (formatting, Clippy, workspace tests, wasm and license checks). New coverage includes an analytic NC golden, randomized remaining-interval checks, roughing/floor/wall finishing, onion skins, inch conversion, ramp/helix slopes including a zero retract height, invalid input and pass limits, rejection on other operation kinds, and unchanged output at zero start depth. CLI output also passes read-back, modal audit and IR verification. Existing golden files are unchanged.DarkBiscuits, co-authored with Codex. Implemented from CAMpanion's own sources and synthetic fixtures. No physical machining tests have been performed.