test: fix Midnight CI event helper setup#979
Merged
Merged
Conversation
Restore the bounded test-offer helper expected by the new Take event test and clear the unused receiver on the helper buy offer. Verification: - forge fmt src test script certora --check - forge lint src test script certora --deny notes - forge build --force --sizes
MathisGD
approved these changes
Jun 5, 2026
QGarchery
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_setupMarketOffer(market, maxUnits)test helper used by the newTakeevent fuzz test from test: events & TickSpacingSetter (2) #924.UnusedReceiverMustBeZerovalidation.Request Context
forgeandforge-oldfail during compilation attest/TakeTest.sol:126andtest/TakeTest.sol:135withWrong argument count for function call: 2 arguments given but expected 1.Test Plan
forge fmt src test script certora --checkforge lint src test script certora --deny notesforge build --force --sizesforgeworkflow on PR headd27aedbd40df34dee7896bacc553c62adc6506baforge-oldworkflow on PR headd27aedbd40df34dee7896bacc553c62adc6506bacertoraworkflow — still in progressforge test --force --match-path test/TakeTest.sol --match-test testTakeEmitsEvent -vvvlocally — Slack-host Forge reachesEvmError: NotActivatedafter compilation/event path; GitHubforgeworkflow passed the full repo test matrix.Requested by: <@U02NB58F6R3>