Skip to content

test: fix Midnight CI event helper setup#979

Merged
QGarchery merged 1 commit into
mainfrom
hermes/fix-midnight-ci-event-helper-1780652728
Jun 5, 2026
Merged

test: fix Midnight CI event helper setup#979
QGarchery merged 1 commit into
mainfrom
hermes/fix-midnight-ci-event-helper-1780652728

Conversation

@prd-carapulse
Copy link
Copy Markdown
Contributor

@prd-carapulse prd-carapulse Bot commented Jun 5, 2026

Summary

  • Restore the bounded _setupMarketOffer(market, maxUnits) test helper used by the new Take event fuzz test from test: events & TickSpacingSetter (2) #924.
  • Clear the unused buy-offer maker-seller receiver before the helper buy fill, matching main's UnusedReceiverMustBeZero validation.

Request Context

  • Initiator: Mathis / Slack: <@U02NB58F6R3> / GitHub: @MathisGD
  • Initial Slack thread: C0B520ZTPJM / thread_ts 1780651759.014659
  • Additional context: main CI is red after test: events & TickSpacingSetter (2) #924; forge and forge-old fail during compilation at test/TakeTest.sol:126 and test/TakeTest.sol:135 with Wrong argument count for function call: 2 arguments given but expected 1.
  • Rationale: Restore Midnight CI.

Test Plan

  • forge fmt src test script certora --check
  • forge lint src test script certora --deny notes
  • forge build --force --sizes
  • GitHub forge workflow on PR head d27aedbd40df34dee7896bacc553c62adc6506ba
  • GitHub forge-old workflow on PR head d27aedbd40df34dee7896bacc553c62adc6506ba
  • GitHub certora workflow — still in progress
  • forge test --force --match-path test/TakeTest.sol --match-test testTakeEmitsEvent -vvv locally — Slack-host Forge reaches EvmError: NotActivated after compilation/event path; GitHub forge workflow passed the full repo test matrix.

Requested by: <@U02NB58F6R3>

Restore the bounded test-offer helper expected by the new Take event test and clear the unused receiver on the helper buy offer.

Verification:
- forge fmt src test script certora --check
- forge lint src test script certora --deny notes
- forge build --force --sizes
@QGarchery QGarchery merged commit 2e32687 into main Jun 5, 2026
42 checks passed
@QGarchery QGarchery deleted the hermes/fix-midnight-ci-event-helper-1780652728 branch June 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants