Conversation
QGarchery
approved these changes
Jun 2, 2026
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
adhusson
reviewed
Jun 3, 2026
adhusson
reviewed
Jun 3, 2026
adhusson
reviewed
Jun 3, 2026
| function isRatified(Offer memory offer, bytes memory ratifierData) external view returns (bytes32) { | ||
| (Signature memory sig, bytes32 root, uint256 leafIndex, bytes32[] memory proof) = | ||
| abi.decode(ratifierData, (Signature, bytes32, uint256, bytes32[])); | ||
| require(proof.length <= 20, HashLib.TreeTooHigh()); |
Contributor
There was a problem hiding this comment.
Strange since this reverts later anyway.
adhusson
reviewed
Jun 3, 2026
| function isRatified(Offer memory offer, bytes memory ratifierData) external view returns (bytes32) { | ||
| (bytes32 root, uint256 leafIndex, bytes32[] memory proof) = | ||
| abi.decode(ratifierData, (bytes32, uint256, bytes32[])); | ||
| require(proof.length <= 20, HashLib.TreeTooHigh()); |
Contributor
There was a problem hiding this comment.
Will we limit length to 20 in all future ratifiers? Wdyt moving the proof size limit comment just to ecrecover ratifier and removing the proof length checks.
Contributor
Author
There was a problem hiding this comment.
it's 1M offers so I don't see any use-case for going above
Contributor
There was a problem hiding this comment.
Agree we don't care it's just that if we enforce consistency here we need to remember to be consistent in the future ones (otherwise it doesn't make sense to add the require in the setter ratifier here)
adhusson
reviewed
Jun 3, 2026
MathisGD
commented
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cantina.xyz/code/81abfa1d-eee2-4afd-9c3b-8134f4d0254b/findings/3