Make inherit_ryukyu be regulated mainly by the allow and not the potential - #153
Open
rogerburks wants to merge 1 commit into
Open
Make inherit_ryukyu be regulated mainly by the allow and not the potential#153rogerburks wants to merge 1 commit into
rogerburks wants to merge 1 commit into
Conversation
…ntial For inherit_ryukyu, moves much of the potential to the allow for better visibility of gatekeeper conditions. This was done by request from another player who played as Japan. The benefit of this is to allow the player to better understand the requirements for annexation of Ryukyu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #152
As a request from someone else who played as Japan, I intend to move much of the
potentialto theallow, while keeping the value of thepotentialas a gatekeeper for visibility. The point of this is to make the requirements for annexing Ryukyu more visible, so that the player can better plan to do this effectively. Player protection remains.Specifically, I mean this text:
ccHFM/ccHFM/decisions/Japan.txt
Lines 1247 to 1261 in 47becfb
The potential has a section added to ensure that only Qing, Japan, and Tokugawa Japan can see it.