Event 99101 is changed to occur when the player is Afghanistan - #144
Open
rogerburks wants to merge 1 commit into
Open
Event 99101 is changed to occur when the player is Afghanistan#144rogerburks wants to merge 1 commit into
rogerburks wants to merge 1 commit into
Conversation
Event 99101 was problematic because there was no reason for the player to expect it to be ai-only. I have changed this to no longer be the case. Additionally, I have added a new events file to provide notifications to tags that experience ENG flavor without having previously been notified by it. I expect to use this file for other missing notifications, for the Trucial States and other tags that are impacted by older flavor code, especially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #143
Event
99101was problematic because there was no reason for the player to expect it to be ai-only. I have changed this to no longer be the case.Additionally, I have added a new events file to provide notifications to tags that experience flavor involving other tags in older code, without having previously been notified by it. I expect to use this file for other missing notifications, for the Trucial States and other tags that are impacted by older flavor code, especially. For instance, the Trucial States are never notified that Bahrain and Qatar have been annexed to them.
This file will likely see heavy use from
ENGflavor, although most likely France flavor and other older code may need to use it. I have done this in order to avoid adding problematic event numbers to older files. I have chosen4000000as the starting event number, since 4 resembles P for "Player notifications."