Prevent core removal for existing tags in most cases - #140
Open
rogerburks wants to merge 1 commit into
Open
Conversation
This was
linked to
issues
Feb 16, 2022
rogerburks
force-pushed
the
rbx4/CoreRemovalExistingColonialTagFix
branch
from
February 17, 2022 08:32
8d97168 to
19bbaa5
Compare
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivlized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should not occur while the tag still exists. This is different from a situation where tags give up cores in treaties, when this fix should not be applied. Additionally, I have allowed core removal in cases where the tag no longer exists, so that the simulation occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything. In the course of making changes, I removed `cleanup_colonial_cores`, since that decision should not exist if things function as intended. I changed `organize_ghana` and `reorganize_ghana` to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana. I removed a few apparently arbitrary Malay core changes in `97122`, `Anglo-Siamese Treaty of 1909`, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces. The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed [in this post](#70 (comment)). Found an overlooked core removal of potentially existing Kurdish tags. Acadia core removal now removes the cores on Maritime Union territory as well. Louisiana core removal now covers the possibility of USA core removal.
rogerburks
force-pushed
the
rbx4/CoreRemovalExistingColonialTagFix
branch
from
February 17, 2022 08:38
ebd7002 to
0107dbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivilized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should arguably not occur under many conditions while the tag still exists. Gameplay of a large number of tags is affected, including most tags from Africa, Malaysia, and Indonesia. Rupert's Land, Louisiana, and Acadia are civilized tags that are also affected.
The core removal method that I chose is a little longer than the usual method, but it has worked in all tests to remove cores only and precisely when and how I wanted:
ccHFM/ccHFM/decisions/New Colonies.txt
Lines 5510 to 5521 in dc9c836
An exception where core removal seems justified, is when tags give up cores in treaties and through other agreements. Under those circumstances, this fix is not applied. Additionally, I have allowed core removal in cases where the tag no longer exists, such that simulated historical change occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything.
In the course of making changes, I removed
cleanup_colonial_cores, since that decision should not exist if core removal functions as intended.I changed
organize_ghanaandreorganize_ghanato require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana.I removed a few apparently arbitrary Malay core changes in
97122,Anglo-Siamese Treaty of 1909, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces.The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed in this post.