Easier discovery of modern cavalry for westernized tags - #108
Open
rogerburks wants to merge 1 commit into
Open
Conversation
The 2% discovery rate for hussars (especially) seems draconian, especially considering that it is possible to discover tanks and airplanes before discovering modern cavalry. This fix addresses that by making the discovery rate 100% for westernized tags. This seems appropriate since hussars may have historical origins as early as the late 14th century. The operative part of the code to fix is here, adding a 98 modifier for westernized tags: https://github.com/moretrim/ccHFM/blob/e9e6e9bad7e585acd1b082da13b73e0374f1d6e5/ccHFM/inventions/army_inventions.txt#L1202-L1214 Optionally, a there could be added a non-zero chance for non-westernized tags to discover them under certain reforms, but I have not added this.
moretrim
reviewed
Jul 18, 2021
Owner
There was a problem hiding this comment.
PR is good to go but I’m going to leave this open for some time. Reasons being:
- this is a gameplay change relative to upstream, so I want to mark it as experimental
- I have to go around implementing the preference system (#112), to give player control over experimental features
- that control means invention chances will have to be conditional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #107
The 2% discovery rate for hussars (especially) seems draconian, especially considering that it is possible in-game to discover tanks and airplanes before discovering modern cavalry. This fix addresses the problem by making the discovery rate 100% for westernized tags that have
military_staff_system. This seems appropriate since hussars may have historical origins as early as the late 14th century.The operative part of the code to fix is here, adding a 98 modifier for westernized tags:
ccHFM/ccHFM/inventions/army_inventions.txt
Lines 1202 to 1214 in e9e6e9b
Optionally, a there could be added a non-zero chance for non-westernized tags to discover them under certain reforms, but I have not added this.