Rhodesia charter decision can no longer steal provinces

[rogerburks]

References issue #99

UK can no longer steal provinces or, delete cores of existing tags, using the rhodesia_charter decision

The decision rhodesia_charter awards Rhodesian and Malawi provinces to the UK even when other countries own them

ccHFM/ccHFM/decisions/ENG.txt

Lines 291 to 300 in e0ee2ed

	2015 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2013 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2014 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2012 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	790 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2017 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2016 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2018 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2067 = { secede_province = THIS any_pop = { literacy = -0.99 } }
	2066 = { secede_province = THIS any_pop = { literacy = -0.99 } }

The following pair of screenshots were taken on the same game day. Before the decision:

After the decision:

Potentially, this decision should check if the provinces are empty or not, and if they are part of a colonial race, although truly I do not exactly see why this decision should secede_province at all. The UK will normally outrace all other tags at obtaining these provinces, but if it cannot, then the game should reflect that. For this reason, I suggest that the best solution is to simply remove all of the secede_province statements.

Additionally, the decision removes Matabele cores from provinces that are awarded Rhodesia cores, even if Matabele still exists.

Given all of this, my proposed fix looks like this, with unowned provinces unmodified except for retaining any core addition. This is because provinces need not be owned for claims on them to occur. The UK can no longer take owned provinces away, and Matabele keeps its cores if it exists. The code that I used is experimental from my perspective, but it worked in tests with and without Matabele existing:

[rogerburks]

This pull request does not accomplish what I set out to do. I provided a fix on my fork:

rogerburks@66542fa