Skip to content

Append .hang suffix to broadcast names#96

Open
kixelated wants to merge 1 commit intomainfrom
claude/update-broadcast-names-8lBfI
Open

Append .hang suffix to broadcast names#96
kixelated wants to merge 1 commit intomainfrom
claude/update-broadcast-names-8lBfI

Conversation

@kixelated
Copy link
Copy Markdown
Collaborator

Watch defaults to bbb.hang on the demo path; publish components
generate -.hang names.

https://claude.ai/code/session_01LMRniVBb54fti5yCjTdhTv

Watch defaults to bbb.hang on the demo path; publish components
generate <adjective>-<animal>.hang names.

https://claude.ai/code/session_01LMRniVBb54fti5yCjTdhTv
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026

Review Change Stack

Walkthrough

This pull request adds a .hang suffix to broadcast names across the publish and watch flow. On the publish side, both the Publish and PublishEmbed components append .hang to the uniquely generated name. On the watch side, both the Watch and WatchEmbed components default to names with the .hang suffix when query parameters are absent, and the Watch component uses the .hang suffix to discriminate relay URL path selection between demo and anonymous routes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Append .hang suffix to broadcast names' directly and clearly summarizes the main change across all modified files.
Description check ✅ Passed The description is related to the changeset, explaining that watch defaults to 'bbb.hang' and publish components generate '-.hang' names, which matches the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/update-broadcast-names-8lBfI
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/update-broadcast-names-8lBfI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/watch-embed.tsx (1)

5-5: ⚡ Quick win

Consider extracting the default broadcast name to a shared constant.

The string literal "bbb.hang" appears in multiple files (here and in src/components/watch.tsx lines 8 and 10). Extracting it to a shared constant would improve maintainability and ensure consistency if the default name needs to change.

♻️ Suggested approach

Create a shared constants file (e.g., src/lib/constants.ts):

export const DEFAULT_BROADCAST_NAME = "bbb.hang";

Then import and use it across components:

+import { DEFAULT_BROADCAST_NAME } from "@/lib/constants";
+
 export default function WatchEmbed() {
 	const params = new URLSearchParams(window.location.search);
-	const name = params.get("name") ?? "bbb.hang";
+	const name = params.get("name") ?? DEFAULT_BROADCAST_NAME;

Apply the same pattern in src/components/watch.tsx.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/watch-embed.tsx` at line 5, Extract the hard-coded default
broadcast name into a shared constant (e.g., DEFAULT_BROADCAST_NAME) and replace
the literal usage in watch-embed.tsx (the const name = params.get("name") ??
"bbb.hang";) with params.get("name") ?? DEFAULT_BROADCAST_NAME; do the same in
src/components/watch.tsx where "bbb.hang" is used; create the constant in a new
module (e.g., export const DEFAULT_BROADCAST_NAME = "bbb.hang" in
src/lib/constants.ts) and import it where needed to ensure consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/watch-embed.tsx`:
- Line 5: Extract the hard-coded default broadcast name into a shared constant
(e.g., DEFAULT_BROADCAST_NAME) and replace the literal usage in watch-embed.tsx
(the const name = params.get("name") ?? "bbb.hang";) with params.get("name") ??
DEFAULT_BROADCAST_NAME; do the same in src/components/watch.tsx where "bbb.hang"
is used; create the constant in a new module (e.g., export const
DEFAULT_BROADCAST_NAME = "bbb.hang" in src/lib/constants.ts) and import it where
needed to ensure consistency.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cbce1b2e-fdac-4826-8b67-4f50906e2acf

📥 Commits

Reviewing files that changed from the base of the PR and between 79d896d and b5a3fd4.

📒 Files selected for processing (4)
  • src/components/publish-embed.tsx
  • src/components/publish.tsx
  • src/components/watch-embed.tsx
  • src/components/watch.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants