fix realpath implementation on Windows#426
Merged
Merged
Conversation
Guest0x0
force-pushed
the
fix-windows-realpath
branch
from
2ab6e4b to
814f4ec
Compare
Coverage Report for CI Build 500Coverage increased (+0.004%) to 77.552%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #404
Previously
@fs.realpathusesGetFullPathNameWon Windows, which does not deference symlink/reparse point. This PR fixes the implementation and useGetFinalPathNameByHandleWinstead. This PR also eliminates the allocation of MoonBit object inside the realpath thread pool job, making the code easier to port to WASM backend. This is not solely for WASM compatibility, though:GetFinalPathNameByHandleWreturn path with extended length prefix\\?\, which need to be trimmed, so one extra layer of copy is unavoidable.