[codex] add checked process runner#391
Draft
bobzhang wants to merge 1 commit into
Draft
Conversation
Coverage Report for CI Build 354Coverage decreased (-0.02%) to 79.333%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a high-level
@process.run_checkedwrapper for callers that want non-zero process exits to raise instead of manually checking the returned status code.@process.NonZeroExitwithexit_code,cmd, andargs@process.runbehavior unchanged: it still returns the child exit statusValidation
moon check src/process --target native(passes; existing unrelated@buffer.new()deprecation warning insrc/fs/tmpdir.mbt)moon test src/process/wait_test.mbt --target native(passes)moon test src/process --target native(passes on rerun; first run hit a transient orphan-cancellation timing failure, isolated rerun of that test passed)moon info(passes; reports existing/untracked warnings fromexamples/cancel_demoplus existing deprecation warnings)git diff --check