Repository navigation
refactor(ipa): simplyfy bool expression using DeMorgan's law - #1547
Merged
Merged
Conversation
andreaangiolillo
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
The implementation is behaviorally unchanged, contrary to the logic correction claimed in the PR description.
1 open finding
What changed in this PR
Refactors the IPA-113 singleton eligibility condition using De Morgan’s law without changing behavior.
Changes:
- Rewrites the boolean condition into an equivalent, flatter expression.
| File | Description |
|---|---|
tools/spectral/ipa/rulesets/functions/IPA113SingletonHasUpdateMethod.js |
Simplifies the singleton eligibility guard. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| const resourcePathItems = getResourcePathItems(resourcePath, oas.paths); | ||
|
|
||
| if (!(isResourceCollectionIdentifier(resourcePath) && isSingletonResource(resourcePathItems))) { | ||
| if (!isResourceCollectionIdentifier(resourcePath) || !isSingletonResource(resourcePathItems)) { |
andreaangiolillo
marked this pull request as ready for review
October 8, 2026 10:58
andreaangiolillo
enabled auto-merge (squash)
October 8, 2026 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR makes a small logic simplification to the
IPA113SingletonHasUpdateMethodSpectral rule function to improve readability.