Repository navigation
refactor(ipa): Move grammaticalWords and ignoreList to shared utility file - #1356
Closed
julius-jogela wants to merge 6 commits into
Closed
julius-jogela wants to merge 6 commits into
julius-jogela wants to merge 6 commits into
Conversation
… file - Create new utility file grammaticalWordsAndIgnoreList.js with shared configuration - Update IPA-126 and IPA-117 functions to import from shared utility instead of YAML - Remove hardcoded lists from IPA-126.yaml and IPA-117.yaml for cleanup - All tests pass: 696 passed, no regressions
julius-jogela
requested review from
andreaangiolillo,
drinkbird,
lovisaberggren,
matt-condon,
saisundar,
wtrocki and
yelizhenden-mdb
July 7, 2026 09:31
julius-jogela
force-pushed
the
CLOUDP-373281-move-lists-to-util
branch
2 times, most recently
from
July 7, 2026 09:39
536a905 to
662ab2c
Compare
Member
|
@julius-jogela @yelizhenden-mdb While we're working on this, can we make sure there's a way to override the word list in the package? Embedding a word list directly in the package isn't a typical use case for a library, and maintaining those lists creates ongoing overhead — every new word requires a release and update of downstream clients that require that new word. I think we can:
|
julius-jogela
force-pushed
the
CLOUDP-373281-move-lists-to-util
branch
from
July 7, 2026 10:12
662ab2c to
2a21cc4
Compare
… file - Merge IPA-126 and IPA-117 lists into single shared IGNORE_LIST and GRAMMATICAL_WORDS - Update IPA126TagNamesShouldUseTitleCase.js to use shared lists - Update IPA117OperationSummaryFormat.js to use shared lists - Remove hardcoded lists from IPA-126.yaml and IPA-117.yaml - Add temporary override for X.509 Authentication tag (xgen-IPA-126-tag-names-should-use-title-case) while upstream specs update - All 696 tests pass, npm run ipa-validation passes
julius-jogela
force-pushed
the
CLOUDP-373281-move-lists-to-util
branch
from
July 7, 2026 11:25
2a21cc4 to
dfba04e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate
grammaticalWordsandignoreListconfiguration from IPA-126 and IPA-117 rulesets into a shared utility file to eliminate duplication and maintain a single source of truth.Changes
/tools/spectral/ipa/rulesets/functions/utils/grammaticalWordsAndIgnoreList.jswith 4 exported constantsIPA126TagNamesShouldUseTitleCase.jsto import from shared utility instead of receiving parameters from YAMLIPA117OperationSummaryFormat.jsto import from shared utility instead of receiving parameters from YAMLignoreListandgrammaticalWordsfromIPA-126.yamlandIPA-117.yamlfor cleanupRelated Ticket
Closes CLOUDP-373281
Testing