Repository navigation
CLOUDP-373281: Move grammaticalWords and ignoreList to shared utility… - #1355
Closed
julius-jogela wants to merge 2 commits into
Closed
julius-jogela wants to merge 2 commits into
julius-jogela wants to merge 2 commits into
Conversation
… file - Create new utility file grammaticalWordsAndIgnoreList.js with shared configuration - Update IPA-126 and IPA-117 functions to import from shared utility instead of YAML - Remove hardcoded lists from IPA-126.yaml and IPA-117.yaml for cleanup - All tests pass: 696 passed, no regressions
julius-jogela
requested review from
andmatei,
andreaangiolillo,
drinkbird,
maks-m-mongo-leaf,
matt-condon,
saisundar and
wtrocki
July 7, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate
grammaticalWordsandignoreListconfiguration from IPA-126 and IPA-117 rulesets into a shared utility file to eliminate duplication and maintain a single source of truth.Proposed changes
/tools/spectral/ipa/rulesets/functions/utils/grammaticalWordsAndIgnoreList.jswith 4 exported constantsIPA126TagNamesShouldUseTitleCase.jsto import from shared utility instead of receiving parameters from YAMLIPA117OperationSummaryFormat.jsto import from shared utility instead of receiving parameters from YAMLignoreListandgrammaticalWordsfromIPA-126.yamlandIPA-117.yamlfor cleanupJira ticket: CLOUDP-373281
Closes CLOUDP-373281
Checklist
Changes to Spectral
Further comments
This refactoring reduces code duplication and improves maintainability by: