Skip to content

feat: CLOUDP-380504 Update Cloud Backup Restorejobs resource#1623

Draft
maastha wants to merge 1 commit intomasterfrom
CLOUDP-380504-cloud-backup-restorejobs
Draft

feat: CLOUDP-380504 Update Cloud Backup Restorejobs resource#1623
maastha wants to merge 1 commit intomasterfrom
CLOUDP-380504-cloud-backup-restorejobs

Conversation

@maastha
Copy link
Copy Markdown
Collaborator

@maastha maastha commented Mar 9, 2026

Proposed changes

Jira ticket: CLOUDP-#

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

Copilot AI review requested due to automatic review settings March 9, 2026 14:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Cloud Backup Restore Jobs CloudFormation resource to migrate the cluster (non-serverless) code paths from Atlas SDK v20231115014 to v20250312013. It also adds three new read-only properties (DesiredTimestamp, PrivateDownloadDeliveryUrls, and Components) to the resource schema, model, and response mapping logic. The serverless paths remain on the older SDK version since serverless instances are deprecated.

Changes:

  • Migrated all cluster-type API calls (CreateBackupRestoreJob, CancelBackupRestoreJob, ListBackupRestoreJobs, GetBackupRestoreJob) from Atlas20231115014 to AtlasSDK (v20250312013), including handling the updated return signatures.
  • Added new schema definitions, model types, and flatten functions for DesiredTimestamp, PrivateDownloadDeliveryUrls, and Components as read-only properties.
  • Fixed example templates to properly reference InstanceName/InstanceType parameters and added corresponding documentation files.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cfn-resources/cloud-backup-restore-jobs/mongodb-atlas-cloudbackuprestorejobs.json Added new type definitions and read-only properties for DesiredTimestamp, PrivateDownloadDeliveryUrls, Components
cfn-resources/cloud-backup-restore-jobs/cmd/resource/model.go Auto-generated model with new struct types for the added schema definitions
cfn-resources/cloud-backup-restore-jobs/cmd/resource/resource.go Migrated cluster paths to new SDK, added flatten functions, updated serverless handlers with nil-guard logic
examples/cloud-backup-restore-jobs/restore.json Renamed ClusterName → InstanceName, added InstanceType property
examples/cloud-backup-restore-jobs/restore_synchronous.json Fixed InstanceName mapping, added InstanceType property
cfn-resources/cloud-backup-restore-jobs/docs/README.md Added documentation for new read-only properties
cfn-resources/cloud-backup-restore-jobs/docs/desiredtimestamp.md New doc for DesiredTimestamp type
cfn-resources/cloud-backup-restore-jobs/docs/privatedownloaddeliveryurl.md New doc for PrivateDownloadDeliveryUrl type
cfn-resources/cloud-backup-restore-jobs/docs/component.md New doc for Component type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions Bot added the stale label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants