feat: CLOUDP-380504 Update Cloud Backup Restorejobs resource#1623
feat: CLOUDP-380504 Update Cloud Backup Restorejobs resource#1623
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Cloud Backup Restore Jobs CloudFormation resource to migrate the cluster (non-serverless) code paths from Atlas SDK v20231115014 to v20250312013. It also adds three new read-only properties (DesiredTimestamp, PrivateDownloadDeliveryUrls, and Components) to the resource schema, model, and response mapping logic. The serverless paths remain on the older SDK version since serverless instances are deprecated.
Changes:
- Migrated all cluster-type API calls (
CreateBackupRestoreJob,CancelBackupRestoreJob,ListBackupRestoreJobs,GetBackupRestoreJob) fromAtlas20231115014toAtlasSDK(v20250312013), including handling the updated return signatures. - Added new schema definitions, model types, and flatten functions for
DesiredTimestamp,PrivateDownloadDeliveryUrls, andComponentsas read-only properties. - Fixed example templates to properly reference
InstanceName/InstanceTypeparameters and added corresponding documentation files.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cfn-resources/cloud-backup-restore-jobs/mongodb-atlas-cloudbackuprestorejobs.json |
Added new type definitions and read-only properties for DesiredTimestamp, PrivateDownloadDeliveryUrls, Components |
cfn-resources/cloud-backup-restore-jobs/cmd/resource/model.go |
Auto-generated model with new struct types for the added schema definitions |
cfn-resources/cloud-backup-restore-jobs/cmd/resource/resource.go |
Migrated cluster paths to new SDK, added flatten functions, updated serverless handlers with nil-guard logic |
examples/cloud-backup-restore-jobs/restore.json |
Renamed ClusterName → InstanceName, added InstanceType property |
examples/cloud-backup-restore-jobs/restore_synchronous.json |
Fixed InstanceName mapping, added InstanceType property |
cfn-resources/cloud-backup-restore-jobs/docs/README.md |
Added documentation for new read-only properties |
cfn-resources/cloud-backup-restore-jobs/docs/desiredtimestamp.md |
New doc for DesiredTimestamp type |
cfn-resources/cloud-backup-restore-jobs/docs/privatedownloaddeliveryurl.md |
New doc for PrivateDownloadDeliveryUrl type |
cfn-resources/cloud-backup-restore-jobs/docs/component.md |
New doc for Component type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
Proposed changes
Jira ticket: CLOUDP-#
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments