Skip to content

chore: Fix stream-connection tests #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manupedrozo merged 3 commits into from
Dec 3, 2025
Merged

chore: Fix stream-connection tests #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16c9b36
Remove mdbVersion flag from tests
manupedrozo Dec 3, 2025
c841c01
Fix update dbRole
manupedrozo Dec 3, 2025
ea5a330
Delete stream instance before deleting the project
manupedrozo Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cfn-resources/stream-connection/test/cfn-test-create-inputs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ clusterName="cluster-$RANDOM"
atlas streams instances create "${instanceName}" --projectId "${projectId}" --region VIRGINIA_USA --provider ${cloudProvider}
echo -e "Created StreamInstance \"${instanceName}\""

atlas clusters create "${clusterName}" --projectId "${projectId}" --backup --provider AWS --region US_EAST_1 --members 3 --tier M10 --mdbVersion 6.0 --diskSizeGB 10 --output=json
atlas clusters create "${clusterName}" --projectId "${projectId}" --backup --provider AWS --region US_EAST_1 --members 3 --tier M10 --diskSizeGB 10 --output=json
Copy link
Copy Markdown
Collaborator

@maastha maastha Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also check if any other scripts have this?

Copy link
Copy Markdown
Collaborator Author

@manupedrozo manupedrozo Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more have mdbVersion but none with 6.0. Should look into removing those as well.

atlas clusters watch "${clusterName}" --projectId "${projectId}"
echo -e "Created Cluster \"${clusterName}\""

Expand Down
9 changes: 8 additions & 1 deletion cfn-resources/stream-connection/test/cfn-test-delete-inputs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ function usage {
}

projectId=$(jq -r '.ProjectId' ./inputs/inputs_1_create.json)

clusterName=$(jq -r '.ClusterName' ./inputs/inputs_1_create.json)
instanceName=$(jq -r '.InstanceName' ./inputs/inputs_1_create.json)

if atlas cluster delete "${clusterName}" --projectId "${projectId}" --force; then
echo "deleting cluster with name ${clusterName}"
Expand All @@ -25,6 +25,13 @@ if [ "$status" -eq 0 ]; then
echo "Cluster '${clusterName}' has been successfully watched until deletion."
fi

#delete stream instance
if atlas streams instances delete "${instanceName}" --projectId "${projectId}" --force; then
echo "deleting stream instance with name ${instanceName}"
else
echo "failed to delete the stream instance with name ${instanceName}"
fi

#delete project
if atlas projects delete "$projectId" --force; then
echo "$projectId project deletion OK"
Expand Down
2 changes: 1 addition & 1 deletion cfn-resources/stream-connection/test/inputs_1_update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"ConnectionName": "ConnectionNameCluster",
"Type": "Cluster",
"DbRoleToExecute": {
"Role": "readWrite",
"Role": "readWriteAnyDatabase",
"Type": "BUILT_IN"
}
}
Loading