(DOCSP-53418) MongoDB::Atlas::FlexCluster README initial draft#1440
(DOCSP-53418) MongoDB::Atlas::FlexCluster README initial draft#1440jromo-mdb wants to merge 4 commits intomongodb:masterfrom
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: CONTRIBUTING.md |
There was a problem hiding this comment.
Pull Request Overview
This PR adds initial documentation for the MongoDB::Atlas::FlexCluster CloudFormation resource, including setup instructions and important deprecation notices.
- Creates a new README for the flex-cluster example with step-by-step activation and template creation instructions
- Updates the flex-cluster resource README with improved description, deprecation warning, and corrected links
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/flex-cluster/README.md | New documentation providing activation steps and template usage guidance |
| cfn-resources/flex-cluster/README.md | Enhanced description with deprecation notice and updated example link |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Your FlexCluster Resource is ready to use. | ||
|
|
||
| ## Step 2: Create template using [flex-cluster.json](flex-cluster.json) | ||
| Note: Make sure you are providing appropriate vales for |
There was a problem hiding this comment.
Typo in 'vales' should be 'values'.
| Note: Make sure you are providing appropriate vales for | |
| Note: Make sure you are providing appropriate values for |
| Resource for managing [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters). | ||
| The flex cluster resource provides access to your [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters) configurations and enables you to create, edit, and delete flex clusters. For more information, see [The MongoDB Atlas Flex Tier](https://www.mongodb.com/company/blog/product-release-announcements/dynamic-workloads-predictable-costs-mongodb-atlas-flex-tier). | ||
|
|
||
| *Important:* Use the `MongoDB::Atlas::Cluster` resource instead of the ``MongoDB::Atlas::FlexCluster`` resource to create and manage flex clusters. `MongoDB::Atlas::Cluster` supports flex clusters and future upgrades will only be available through this resource. For more information, see [`MongoDB::Atlas::Cluster` README](../cluster/README.md). |
There was a problem hiding this comment.
Inconsistent backtick formatting around 'MongoDB::Atlas::FlexCluster'. It uses double backticks (``) while other resource names use single backticks (`).
| *Important:* Use the `MongoDB::Atlas::Cluster` resource instead of the ``MongoDB::Atlas::FlexCluster`` resource to create and manage flex clusters. `MongoDB::Atlas::Cluster` supports flex clusters and future upgrades will only be available through this resource. For more information, see [`MongoDB::Atlas::Cluster` README](../cluster/README.md). | |
| *Important:* Use the `MongoDB::Atlas::Cluster` resource instead of the `MongoDB::Atlas::FlexCluster` resource to create and manage flex clusters. `MongoDB::Atlas::Cluster` supports flex clusters and future upgrades will only be available through this resource. For more information, see [`MongoDB::Atlas::Cluster` README](../cluster/README.md). |
…tes and parameters section.
| ## Attributes and Parameters | ||
|
|
||
| See the [resource docs](docs/README.md). | ||
| See the [resource docs](docs/README.md) and the [Flex Clusters API reference](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters). |
There was a problem hiding this comment.
I wouldn't change this sentence as CfnFlexCluster has different attributes to CfnCluster and this can confuse customers into believe that they need to use the CfnFlexCluster attribute format in their CfnCluster resources.
|
|
||
| ## Description | ||
|
|
||
| Resource for managing [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters). |
There was a problem hiding this comment.
please use a branch in the repo instead of your personal GH org
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Resource for managing [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters). | ||
| The flex cluster resource provides access to your [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters) configurations and enables you to create, edit, and delete flex clusters. For more information, see [The MongoDB Atlas Flex Tier](https://www.mongodb.com/company/blog/product-release-announcements/dynamic-workloads-predictable-costs-mongodb-atlas-flex-tier). | ||
|
|
||
| *Note:* Upgrades to or from flex clusters are currently unavailable. We expect to support upgrades to or from flex clusters in the forseeable future. |
There was a problem hiding this comment.
Spelling error: 'forseeable' should be 'foreseeable'.
| *Note:* Upgrades to or from flex clusters are currently unavailable. We expect to support upgrades to or from flex clusters in the forseeable future. | |
| *Note:* Upgrades to or from flex clusters are currently unavailable. We expect to support upgrades to or from flex clusters in the foreseeable future. |
| ## Step 1: Activate the cluster resource in cloudformation | ||
| Step a: Create Role using [execution-role.yaml](https://github.com/mongodb/mongodbatlas-cloudformation-resources/blob/master/examples/execution-role.yaml) in CFN resources folder. | ||
|
|
||
| Step b: Search for Mongodb::Atlas::FlexCluster resource. |
There was a problem hiding this comment.
Inconsistent capitalization: 'Mongodb' should be 'MongoDB' to match the standard formatting used elsewhere in the documentation.
| Step b: Search for Mongodb::Atlas::FlexCluster resource. | |
| Step b: Search for MongoDB::Atlas::FlexCluster resource. |
| Note: Make sure you are providing appropriate values for: | ||
| 1. OrgId | ||
| 2. ProjectName | ||
| 3. Clustername No newline at end of file |
There was a problem hiding this comment.
[nitpick] Consider using 'ClusterName' or 'Cluster Name' for consistency with typical naming conventions.
| 3. Clustername | |
| 3. ClusterName |
|
Duplicated by #1441 |
Proposed changes
Jira ticket: CLOUDP-#
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments