Skip to content

(DOCSP-53418) MongoDB::Atlas::FlexCluster README initial draft#1440

Closed
jromo-mdb wants to merge 4 commits intomongodb:masterfrom
jromo-mdb:DOCSP-53418
Closed

(DOCSP-53418) MongoDB::Atlas::FlexCluster README initial draft#1440
jromo-mdb wants to merge 4 commits intomongodb:masterfrom
jromo-mdb:DOCSP-53418

Conversation

@jromo-mdb
Copy link
Copy Markdown
Contributor

Proposed changes

Jira ticket: CLOUDP-#

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

Copilot AI review requested due to automatic review settings September 12, 2025 15:51
@jromo-mdb jromo-mdb requested a review from a team as a code owner September 12, 2025 15:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details: CONTRIBUTING.md

No release type found in pull request title "(DOCSP-53418) MongoDB::Atlas::FlexCluster README initial draft". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - chore
 - doc
 - test
 - security
 - remove
 - deprecate
 - refactor
 - perf
 - ci
 - revert
 - style

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds initial documentation for the MongoDB::Atlas::FlexCluster CloudFormation resource, including setup instructions and important deprecation notices.

  • Creates a new README for the flex-cluster example with step-by-step activation and template creation instructions
  • Updates the flex-cluster resource README with improved description, deprecation warning, and corrected links

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
examples/flex-cluster/README.md New documentation providing activation steps and template usage guidance
cfn-resources/flex-cluster/README.md Enhanced description with deprecation notice and updated example link

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread examples/flex-cluster/README.md Outdated
Your FlexCluster Resource is ready to use.

## Step 2: Create template using [flex-cluster.json](flex-cluster.json)
Note: Make sure you are providing appropriate vales for
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in 'vales' should be 'values'.

Suggested change
Note: Make sure you are providing appropriate vales for
Note: Make sure you are providing appropriate values for

Copilot uses AI. Check for mistakes.
Comment thread cfn-resources/flex-cluster/README.md Outdated
Resource for managing [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters).
The flex cluster resource provides access to your [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters) configurations and enables you to create, edit, and delete flex clusters. For more information, see [The MongoDB Atlas Flex Tier](https://www.mongodb.com/company/blog/product-release-announcements/dynamic-workloads-predictable-costs-mongodb-atlas-flex-tier).

*Important:* Use the `MongoDB::Atlas::Cluster` resource instead of the ``MongoDB::Atlas::FlexCluster`` resource to create and manage flex clusters. `MongoDB::Atlas::Cluster` supports flex clusters and future upgrades will only be available through this resource. For more information, see [`MongoDB::Atlas::Cluster` README](../cluster/README.md).
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent backtick formatting around 'MongoDB::Atlas::FlexCluster'. It uses double backticks (``) while other resource names use single backticks (`).

Suggested change
*Important:* Use the `MongoDB::Atlas::Cluster` resource instead of the ``MongoDB::Atlas::FlexCluster`` resource to create and manage flex clusters. `MongoDB::Atlas::Cluster` supports flex clusters and future upgrades will only be available through this resource. For more information, see [`MongoDB::Atlas::Cluster` README](../cluster/README.md).
*Important:* Use the `MongoDB::Atlas::Cluster` resource instead of the `MongoDB::Atlas::FlexCluster` resource to create and manage flex clusters. `MongoDB::Atlas::Cluster` supports flex clusters and future upgrades will only be available through this resource. For more information, see [`MongoDB::Atlas::Cluster` README](../cluster/README.md).

Copilot uses AI. Check for mistakes.
Comment thread cfn-resources/flex-cluster/README.md Outdated
## Attributes and Parameters

See the [resource docs](docs/README.md).
See the [resource docs](docs/README.md) and the [Flex Clusters API reference](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change this sentence as CfnFlexCluster has different attributes to CfnCluster and this can confuse customers into believe that they need to use the CfnFlexCluster attribute format in their CfnCluster resources.


## Description

Resource for managing [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a branch in the repo instead of your personal GH org

@jromo-mdb jromo-mdb requested a review from Copilot September 12, 2025 16:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Resource for managing [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters).
The flex cluster resource provides access to your [Flex Clusters](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/group/endpoint-flex-clusters) configurations and enables you to create, edit, and delete flex clusters. For more information, see [The MongoDB Atlas Flex Tier](https://www.mongodb.com/company/blog/product-release-announcements/dynamic-workloads-predictable-costs-mongodb-atlas-flex-tier).

*Note:* Upgrades to or from flex clusters are currently unavailable. We expect to support upgrades to or from flex clusters in the forseeable future.
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: 'forseeable' should be 'foreseeable'.

Suggested change
*Note:* Upgrades to or from flex clusters are currently unavailable. We expect to support upgrades to or from flex clusters in the forseeable future.
*Note:* Upgrades to or from flex clusters are currently unavailable. We expect to support upgrades to or from flex clusters in the foreseeable future.

Copilot uses AI. Check for mistakes.
## Step 1: Activate the cluster resource in cloudformation
Step a: Create Role using [execution-role.yaml](https://github.com/mongodb/mongodbatlas-cloudformation-resources/blob/master/examples/execution-role.yaml) in CFN resources folder.

Step b: Search for Mongodb::Atlas::FlexCluster resource.
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization: 'Mongodb' should be 'MongoDB' to match the standard formatting used elsewhere in the documentation.

Suggested change
Step b: Search for Mongodb::Atlas::FlexCluster resource.
Step b: Search for MongoDB::Atlas::FlexCluster resource.

Copilot uses AI. Check for mistakes.
Note: Make sure you are providing appropriate values for:
1. OrgId
2. ProjectName
3. Clustername No newline at end of file
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using 'ClusterName' or 'Cluster Name' for consistency with typical naming conventions.

Suggested change
3. Clustername
3. ClusterName

Copilot uses AI. Check for mistakes.
@jromo-mdb jromo-mdb closed this Sep 12, 2025
@jromo-mdb
Copy link
Copy Markdown
Contributor Author

Duplicated by #1441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants